Reuse the CSD sh coefficients if you already have them. #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Or create them for the first time to be reused later on. This addresses some of yeatmanlab#590.
|
Any thoughts about this @36000 ? This does not yet address the issue of bringing in sh coefficients from other software pipelines (e.g., qsirecon/mrtrix), but would save one round of CSD fitting that we are currently doing from happening. I think that in most cases, the order would be that APM would be computed first (for registration) and then these coefficients would get reused for tracking later on. |
|
You can now remove our fit_anisotropic_power_map function, then LGTM |
|
OK - this is now rebased! @36000 : when you get a chance, could you please review/merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or create them for the first time to be reused later on.
This addresses some of #590. Still need to figure out how to convert SH coefficients from mrtrix into our APM.