Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding separate example output directories to avoid name collisions #490

Merged
merged 1 commit into from Oct 6, 2020

Conversation

bloomdt-uw
Copy link
Collaborator

This is related to observation from #443 review. Updating RecoBundle and tract profile examples to place artifacts in corresponding subdirectory. Note that AFQ API does not produce any artifacts in the examples directory and therefore was not changed as part of this work.. For now just placed a working_dir variable in both examples. This should work for both build and local execution.

Figured this was sufficient for now, but I briefly considered passing the working directory variable as part of build process see.

@bloomdt-uw
Copy link
Collaborator Author

May want to adjust sphinx-gallery distclean target to remove these subfolders. see #489 at the moment it will remove the artifacts, but leave the empty folders.

@arokem
Copy link
Collaborator

arokem commented Oct 6, 2020

Thanks for doing this. I'll merge this now, and we can adjust around it.

@arokem arokem merged commit aaa1db4 into yeatmanlab:master Oct 6, 2020
@bloomdt-uw bloomdt-uw deleted the fix_sphinx-gallery-workdirs branch October 6, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants