-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] [DOC] Add matlab to python file conversion functions, add docs for custom tractography integration #599
Conversation
@arokem is there a small matlab file I could use to unit test these new functions? |
Hello @36000! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-11-25 17:32:10 UTC |
@arokem where should I put the mat files I use for testing here? |
You can put them in a |
I believe thats being used already for some s3 tests. I may have to modify those tests to use that folder. For example, it looks like test_get_matching_s3_keys expects everything in that folder to be the same as whats in the test bucket. @richford anything you would like to add to this discussion about how AFQ/tests/data is used? |
9a85f2e
to
c304dc2
Compare
I ended up moving the mock s3 data into a "mocks3" folder in data to separate it from the rest. Anyways, this is ready for review / merge @arokem . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks good! Just a few minor comments/suggestions.
…data to ignore these
Co-authored-by: Ariel Rokem <arokem@gmail.com>
Co-authored-by: Ariel Rokem <arokem@gmail.com>
Co-authored-by: Ariel Rokem <arokem@gmail.com>
Co-authored-by: Ariel Rokem <arokem@gmail.com>
Co-authored-by: Ariel Rokem <arokem@gmail.com>
Co-authored-by: Ariel Rokem <arokem@gmail.com>
Co-authored-by: Ariel Rokem <arokem@gmail.com>
Co-authored-by: Ariel Rokem <arokem@gmail.com>
Co-authored-by: Ariel Rokem <arokem@gmail.com>
Co-authored-by: Ariel Rokem <arokem@gmail.com>
Co-authored-by: Ariel Rokem <arokem@gmail.com>
@arokem I tried using squeeze_me but I got confused by what it was returning. The current system works for the files I have encountered, so I don't know if it would be useful to re-figure it out with squeeze_me. Other than that, this is ready for review / merge. |
Closes #549