Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListIteratorOf should directly wrap a ListIterator instead of a Sticky Scalar and be renamed to ListIteratorEnvelope #1247

Closed
victornoel opened this issue Nov 24, 2019 · 8 comments
Closed

ListIteratorOf should directly wrap a ListIterator instead of a Sticky Scalar and be renamed to ListIteratorEnvelope #1247

victornoel opened this issue Nov 24, 2019 · 8 comments
Assignees
@victornoel
Labels
role/DEV scope
Milestone
1.0

Comments

@victornoel
Copy link
Collaborator

victornoel commented Nov 24, 2019 •
edited

ListIteratorOf should:

  • directly wrap a ListIterator instead of a Sticky Scalar, because this is useless wrapping with decorators.
  • be renamed to ListIteratorEnvelope (and made abstract) because this is really what it is in practice

At the same time, let's remove the useless usage of ListIteratorOf in ListIteratorNoNulls
@0crat
Copy link
Collaborator

0crat commented Nov 24, 2019

@paulodamaso/z please, pay attention to this issue

@victornoel
Copy link
Collaborator Author

@paulodamaso I also noticed that ListIteratorNoNulls delegates uselessly toListIteratorOf but doesn't need to since it wraps already a ListIterator.

This could tackled in this same task.

@victornoel
Copy link
Collaborator Author

@0crat in

@victornoel
Copy link
Collaborator Author

@0crat assign me

@victornoel victornoel added this to the 1.0 milestone Sep 13, 2020
victornoel added a commit to victornoel/cactoos that referenced this issue Sep 13, 2020
@victornoel
(yegor256#1247) ListIteratorOf is now ListIteratorEnvelope
e3ddaa0
@victornoel victornoel mentioned this issue Sep 13, 2020
Merged
@victornoel
Copy link
Collaborator Author

@0crat wait for #1457

@0crat 0crat added the waiting label Sep 13, 2020
victornoel added a commit to victornoel/cactoos that referenced this issue Sep 13, 2020
@victornoel
(yegor256#1247) ListIteratorOf is now ListIteratorEnvelope
19a6df1
victornoel added a commit to victornoel/cactoos that referenced this issue Sep 13, 2020
@victornoel
(yegor256#1247) ListIteratorOf is now ListIteratorEnvelope
86c04a2
victornoel added a commit to victornoel/cactoos that referenced this issue Sep 13, 2020
@victornoel
(yegor256#1247) ListIteratorOf is now ListIteratorEnvelope
07b063e
@0pdd 0pdd mentioned this issue Sep 13, 2020
Closed
@0pdd
Copy link
Collaborator

0pdd commented Sep 13, 2020

@victornoel the puzzle #1459 is still not solved.

@0crat 0crat removed the waiting label Sep 13, 2020
@0crat
Copy link
Collaborator

0crat commented Sep 13, 2020

Job was finished in 8 hours, bonus for fast delivery is possible (see §36)

@0pdd
Copy link
Collaborator

0pdd commented Dec 28, 2020

@victornoel the only puzzle #1459 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@victornoel victornoel

Labels
role/DEV scope
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@victornoel @0crat @0pdd