Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test on Windows for scalar.Retry #1497

Open
victornoel opened this issue Nov 3, 2020 · 4 comments
Open

Fix flaky test on Windows for scalar.Retry #1497

victornoel opened this issue Nov 3, 2020 · 4 comments

Comments

@victornoel
Copy link
Collaborator

The test scalar.RetryTest.runsScalarMultipleTimesWithWait fails only sometimes: https://github.com/yegor256/cactoos/pull/1491/checks?check_run_id=1336830111

We've seen it only on Windows for now and only once.

Let's make the test more robust, either with a simple fix if possible or replacing it with something different that test the same functionality.

@victornoel
Copy link
Collaborator Author

@0crat in

@victornoel
Copy link
Collaborator Author

@0crat status

@0crat
Copy link
Collaborator

0crat commented Jun 12, 2021

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

  • The job #1497 is in scope for 7mon
  • The role is DEV
  • The job is not assigned to anyone
  • The budget is not set yet
  • These users are banned and won't be assigned:
  • Job footprint (restricted area)

@pnatashap
Copy link
Contributor

also faced with this error and add an iteration number to the error message. The error message was

Expected: a value less than or equal to <2024-02-20T15:21:39.556203100Z>
     but: <2024-02-20T15:21:39.556203700Z> was greater than <2024-02-20T15:21:39.556203100Z>

So the difference is 0.0000006 sec = 0.00006 milli sec
I think that is just system accuracy. May be good to compare time up to 0.1 millisec and it should be good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants