Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceOf need an extra ctor with Class argument #1517

Closed
yegor256 opened this issue Dec 28, 2020 · 5 comments
Closed

ResourceOf need an extra ctor with Class argument #1517

yegor256 opened this issue Dec 28, 2020 · 5 comments

Comments

@yegor256
Copy link
Owner

Now I have to do this:

class Foo {
  new ResourceOf("foo.txt", Foo.class.getClassLoader())
}

I believe it would be more convenient if we would have an extra ctor:

class Foo {
  new ResourceOf("foo.txt", Foo.class)
}
@yegor256
Copy link
Owner Author

@victornoel this PR should fix it: #1520

yegor256 added a commit that referenced this issue Dec 31, 2020
yegor256 added a commit that referenced this issue Dec 31, 2020
yegor256 added a commit that referenced this issue Jan 10, 2021
@yegor256
Copy link
Owner Author

@victornoel are you planning to release 0.49 any time soon?

@victornoel
Copy link
Collaborator

@yegor256 I would first like to have #1528 merged at least, but there are no REV available, would you interested in reviewing the PR? Sorry for the late reply :)

@victornoel
Copy link
Collaborator

@yegor256 closing this, 0.49 will be released in #1530 in a few minutes

@0crat
Copy link
Collaborator

0crat commented Jan 16, 2021

Job gh:yegor256/cactoos#1517 is not assigned, can't get performer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants