Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RangeOf Comparable<T> #478

Closed
svendiedrichsen opened this issue Nov 30, 2017 · 7 comments
Closed

RangeOf Comparable<T> #478

svendiedrichsen opened this issue Nov 30, 2017 · 7 comments

Comments

@svendiedrichsen
Copy link
Contributor

svendiedrichsen commented Nov 30, 2017

@yegor256 Would it be interesting to have a RangeOf implementation for Comparable<T> instances? Example PR follows.

@0crat
Copy link
Collaborator

0crat commented Nov 30, 2017

@yegor256 please, pay attention to this issue

@svendiedrichsen svendiedrichsen changed the title RangeOf comparables RangeOf Comparable<T> Nov 30, 2017
@yegor256
Copy link
Owner

yegor256 commented Dec 1, 2017

@svendiedrichsen good idea, would be great to have these ctors too:

new RangeOf(1, 10);
new RangeOf(1L, 10L);
new RangeOf('a', 'z');

@yegor256
Copy link
Owner

yegor256 commented Dec 1, 2017

@svendiedrichsen maybe we have to delete NaturalNumbers...

@svendiedrichsen
Copy link
Contributor Author

@yegor256 I have removed NULL handling and added convenience classes/constructors
new RangeOf.Integer(int,int)
new RangeOf.Long(long,long)
new RangeOf.Character(char,char)
Would you like me to remove now obsolete classes NaturalNumbers etc. ?

@yegor256
Copy link
Owner

yegor256 commented Dec 4, 2017

@svendiedrichsen yes, NaturalNumbers is not required anymore, let's delete it.

@svendiedrichsen
Copy link
Contributor Author

@yegor256 done.

@svendiedrichsen
Copy link
Contributor Author

Changes merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants