Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1533) More variance on some generics #1534

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Conversation

victornoel
Copy link
Collaborator

This is related to #1533, I need it for #1335 but I'm dedicating a PR to it.

@codecov-io
Copy link

codecov-io commented Jan 16, 2021

Codecov Report

Merging #1534 (1fed966) into master (865f249) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1534      +/-   ##
============================================
- Coverage     90.84%   90.81%   -0.04%     
- Complexity     1553     1554       +1     
============================================
  Files           284      284              
  Lines          3672     3668       -4     
  Branches        125      125              
============================================
- Hits           3336     3331       -5     
  Misses          306      306              
- Partials         30       31       +1     
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/cactoos/scalar/Flattened.java 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/main/java/org/cactoos/scalar/Folded.java 100.00% <100.00%> (ø) 4.00 <2.00> (ø)
src/main/java/org/cactoos/scalar/HighestOf.java 100.00% <100.00%> (ø) 6.00 <3.00> (-1.00)
src/main/java/org/cactoos/scalar/LowestOf.java 100.00% <100.00%> (ø) 6.00 <3.00> (-1.00)
src/main/java/org/cactoos/scalar/Reduced.java 100.00% <100.00%> (ø) 5.00 <4.00> (ø)
src/main/java/org/cactoos/scalar/Solid.java 90.00% <0.00%> (-10.00%) 3.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865f249...1fed966. Read the comment docs.

@0crat
Copy link
Collaborator

0crat commented Jan 16, 2021

This pull request #1534 is assigned to @baudoliver7/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @victornoel/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

Copy link
Contributor

@baudoliver7 baudoliver7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victornoel It looks good for me :)

@victornoel
Copy link
Collaborator Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jan 16, 2021

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 1fed966 into yegor256:master Jan 16, 2021
@rultor
Copy link
Collaborator

rultor commented Jan 16, 2021

@rultor merge

@victornoel Done! FYI, the full log is here (took me 8min)

@victornoel victornoel deleted the 1533 branch January 16, 2021 18:12
@0crat 0crat added the qa label Jan 16, 2021
@0crat
Copy link
Collaborator

0crat commented Jan 16, 2021

Job was finished in 1 hours, bonus for fast delivery is possible (see §36)

@0crat
Copy link
Collaborator

0crat commented Jan 16, 2021

@sereshqua/z please review this job completed by @baudoliver7/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the 0crat/scope label Jan 16, 2021
@sereshqua
Copy link

@0crat quality bad

@0crat 0crat added quality/bad and removed qa labels Jan 16, 2021
@0crat
Copy link
Collaborator

0crat commented Jan 16, 2021

Quality is low, no payment, see §31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants