(#1443) Remove redundant tests for SSL #1588
Conversation
|
@andreoss as mentioned in the ticket, the job included replacing calls to external urls with using takes, see #1443 (comment) |
|
@victornoel Moved it to Takes. |
| new FtRemote(new TkFork(new FkRegex("/", new TkText(data.asString())))).exec( | ||
| uri -> new Assertion<>( | ||
| "Must read bytes from HTTPS URL", | ||
| new TextOf(new InputOf(uri)), |
There was a problem hiding this comment.
@andreoss this test seems to exist to test that it works with https, but I don't think that FtRemote is serving https at all…
There was a problem hiding this comment.
@victornoel Than I suggest removing this test completely than. The code under test doesn't depend on protocol at all
There was a problem hiding this comment.
@andreoss ok, that makes sense, and since the code is relying on Java's std lib for http requests, there is no big reason for testing it. Thanks for looking into it
andreoss
changed the title
|
@rultor merge |
@victornoel OK, I'll try to merge now. You can check the progress of the merge here |
@victornoel Done! FYI, the full log is here (took me 9min) |
|
@sereshqua/z please review this job completed by @marceloamadeu/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
@0crat quality bad |
|
Quality is low, no payment, see §31 |
Per #1443