Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Fallback instead of Func #1615

Merged
merged 5 commits into from
Jul 22, 2021
Merged

Use Fallback instead of Func #1615

merged 5 commits into from
Jul 22, 2021

Conversation

andreoss
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2021

Codecov Report

Merging #1615 (08c55a7) into master (6b71044) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1615      +/-   ##
============================================
+ Coverage     90.07%   90.09%   +0.01%     
+ Complexity     1602     1601       -1     
============================================
  Files           298      298              
  Lines          3748     3745       -3     
  Branches        122      122              
============================================
- Hits           3376     3374       -2     
+ Misses          338      337       -1     
  Partials         34       34              
Impacted Files Coverage Δ
src/main/java/org/cactoos/Fallback.java 100.00% <100.00%> (ø)
...rc/main/java/org/cactoos/bytes/UncheckedBytes.java 100.00% <100.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b71044...08c55a7. Read the comment docs.

@victornoel
Copy link
Collaborator

@0crat status

1 similar comment
@victornoel
Copy link
Collaborator

@0crat status

@0crat
Copy link
Collaborator

0crat commented Jun 19, 2021

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

@0crat
Copy link
Collaborator

0crat commented Jun 19, 2021

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

@victornoel
Copy link
Collaborator

@andreoss I was surprised when I saw that UncheckedBytes, contrary to many of the other UncheckedXXX classes this fallback paramter... I'm not convinced there is a real use for this. I would instead propose to remove this parameter at all, here and in the other UncheckedXXX classes. Along with this, we can think about introducing and unifying how all the XXXWithFallback work.

WDYT? If you like the idea and create a ticket for it, I will put it in scope

@victornoel
Copy link
Collaborator

@andreoss one of the tests if failing apparently

@andreoss
Copy link
Contributor Author

@victornoel A flaky test, apparently.

@victornoel
Copy link
Collaborator

@andreoss yep… let's just ignore it ^^

@victornoel
Copy link
Collaborator

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jul 22, 2021

@rultor merge

@victornoel OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 08c55a7 into yegor256:master Jul 22, 2021
@rultor
Copy link
Collaborator

rultor commented Jul 22, 2021

@rultor merge

@victornoel Done! FYI, the full log is here (took me 11min)

@0crat
Copy link
Collaborator

0crat commented Jul 22, 2021

Job gh:yegor256/cactoos#1615 is not assigned, can't get performer

@0pdd
Copy link
Collaborator

0pdd commented Sep 5, 2021

@andreoss the puzzle #1623 is still not solved.

@victornoel
Copy link
Collaborator

@0crat status

@0pdd
Copy link
Collaborator

0pdd commented Jul 11, 2022

@andreoss the puzzle #unknown is still not solved.

@0crat
Copy link
Collaborator

0crat commented Aug 1, 2022

@0crat status (here)

@victornoel This is what I know about this job in C63314D6Z, as in §32:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants