Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1533) Generify org.cactoos.list package #1634

Conversation

DmitryBarskov
Copy link
Contributor

@DmitryBarskov DmitryBarskov commented Apr 1, 2022

For #1533:

Many thanks for your contribution, we truly appreciate it. We will appreciate it even more, if you make sure that you can say "YES" to each point in this short checklist:

This article will help you understand what we are looking for: http://www.yegor256.com/2015/02/09/serious-code-reviewer.html

Thank you for your contribution!

@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #1634 (b7cbd17) into master (2d3d898) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1634   +/-   ##
=========================================
  Coverage     90.10%   90.10%           
  Complexity     1603     1603           
=========================================
  Files           298      298           
  Lines          3749     3749           
  Branches        122      122           
=========================================
  Hits           3378     3378           
  Misses          337      337           
  Partials         34       34           
Impacted Files Coverage Δ
src/main/java/org/cactoos/list/Joined.java 100.00% <ø> (ø)
src/main/java/org/cactoos/list/Immutable.java 100.00% <100.00%> (ø)
...n/java/org/cactoos/list/ImmutableListIterator.java 91.66% <100.00%> (ø)
...main/java/org/cactoos/list/JoinedListIterator.java 75.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3d898...b7cbd17. Read the comment docs.

@DmitryBarskov DmitryBarskov changed the title (#1568) Generify org.cactoos.list package (#1533) Generify org.cactoos.list package Apr 1, 2022
@DmitryBarskov DmitryBarskov force-pushed the issue-1533-generify-list-package branch from 6842ef8 to a5d14ba Compare April 1, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants