Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URI instead of URL #1691

Merged
merged 5 commits into from Feb 24, 2024
Merged

URI instead of URL #1691

merged 5 commits into from Feb 24, 2024

Conversation

h1alexbel
Copy link
Contributor

closes #1690

pnatashap
pnatashap suggested changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@pnatashap pnatashap left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@h1alexbel Codacy errors should be fixed

src/test/java/org/cactoos/io/InputOfTest.java Outdated Show resolved Hide resolved
h1alexbel and others added 3 commits February 24, 2024 12:10
@h1alexbel
Copy link
Contributor Author

@pnatashap thanks for your suggestions, fixed. Take a look, again please

@pnatashap
Copy link
Contributor

@yegor256 please take a look. I think it is needed to support jdk 21+

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Feb 24, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit b798f1b into yegor256:master Feb 24, 2024
8 checks passed
@rultor
Copy link
Collaborator

rultor commented Feb 24, 2024

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 8min)

@h1alexbel h1alexbel deleted the 1690 branch February 24, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnatashap pnatashap pnatashap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build failed on java 21+
4 participants
@h1alexbel @pnatashap @yegor256 @rultor