Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant continue #199

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Conversation

ilnarkhasanov
Copy link
Contributor

@ilnarkhasanov ilnarkhasanov commented Mar 12, 2024

Closes #177

@yegor256
Copy link
Owner

@ilnarkhasanov why pylint and mypy didn't catch this? what do you think?

@ilnarkhasanov
Copy link
Contributor Author

@yegor256

mypy is used for type checking. This case is out of mypy's responsibility.

Speaking about pylint, my assumption is that pylint generally does not cover this case.

@yegor256
Copy link
Owner

@ilnarkhasanov maybe pep8 can catch this? Just fixing the problem is not a solution - we will have similar problems in the future.

@ilnarkhasanov
Copy link
Contributor Author

@yegor256

I got a solution - SonarCloud.

It catches such thing as redundant continue. We can integrate it into out GitHub Actions and set a quality gate in such a way that it blocks the pushing if it is not met.

What else is interesting is that SonarCloud concerns on vulnerabilities on code, cognitive complexity, etc.
image
image

My suggestion: integrate it into GitHub Actions in order to improve cam's code in many ways

@yegor256
Copy link
Owner

@ilnarkhasanov OK, let's integrate it

@ilnarkhasanov
Copy link
Contributor Author

ilnarkhasanov commented Mar 28, 2024

@yegor256

Now we have integrated SonarCloud and this maintainability issue will be closed there automatically if we merge.

Could you merge, please?

@yegor256
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Mar 28, 2024

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Mar 28, 2024

@rultor merge

@ilnarkhasanov @yegor256 Oops, I failed. You can see the full log here (spent 11min)

@yegor256 yegor256 merged commit 2b00060 into yegor256:master Mar 28, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redundant continue in ast.py
3 participants