Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant continue in ast.py #177

Closed
ilnarkhasanov opened this issue Feb 28, 2024 · 5 comments · Fixed by #199
Closed

Redundant continue in ast.py #177

ilnarkhasanov opened this issue Feb 28, 2024 · 5 comments · Fixed by #199

Comments

@ilnarkhasanov
Copy link
Contributor

In this code snippet (ast.py, lines 133-135) continue instruction is redundant.

        if 'Override' in annotations:
            total += 1
            continue

Suggestion:

        if 'Override' in annotations:
            total += 1
@ilnarkhasanov
Copy link
Contributor Author

@yegor256 can you approve this issue, please?

@ilnarkhasanov
Copy link
Contributor Author

@yegor256 can you check it, please?

@yegor256
Copy link
Owner

yegor256 commented Mar 6, 2024

@ilnarkhasanov I agree, but why pylint doesn't complain? Let's try to add some other linter to the build first, which is stronger than pylint.

@ilnarkhasanov
Copy link
Contributor Author

@yegor256 I made a research and I did not find any static analyser that catches this issue.

@ilnarkhasanov
Copy link
Contributor Author

@yegor256 could you check the solution, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants