Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copyright protection #305

Merged
merged 2 commits into from
May 6, 2024
Merged

Add copyright protection #305

merged 2 commits into from
May 6, 2024

Conversation

padjal
Copy link
Contributor

@padjal padjal commented May 3, 2024

This PR adds a copyright check to all code files in the repo as suggested by Issue #189.

If a file, which doesn't have the current year if found, the user is notified and the linting check fails:
image

Added copyright protection to the linting step of the makefiles.

Issue: yegor256#189
@padjal
Copy link
Contributor Author

padjal commented May 3, 2024

@yegor256 Please have a look.

@padjal
Copy link
Contributor Author

padjal commented May 5, 2024

@yegor256 Can you review this?

steps/lint.sh Outdated Show resolved Hide resolved
@yegor256
Copy link
Owner

yegor256 commented May 6, 2024

@padjal looks good, one small suggestion above

Changed the search term in the copyright linting function to check for the whole string, rather than just a single year.

Issue: yegor256#189
@padjal
Copy link
Contributor Author

padjal commented May 6, 2024

@yegor256 Thanks for your suggestion. I have adjusted the code to search for the full string. Please review.

@yegor256 yegor256 merged commit 0d963b5 into yegor256:master May 6, 2024
10 checks passed
@yegor256
Copy link
Owner

yegor256 commented May 6, 2024

@padjal thanks!

@padjal padjal deleted the copyright branch May 6, 2024 07:05
@padjal padjal mentioned this pull request May 6, 2024
This was referenced May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants