Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change years of files for copyright #315

Merged
merged 3 commits into from
May 19, 2024

Conversation

timur-harin
Copy link
Contributor

@timur-harin timur-harin commented May 15, 2024

@yegor256
Studying the details of the project, I noticed that despite the fact that a check for years in the file copyright was added, there were still files with incorrect copyright, I suggest that you fix it

Original issue #189 and fix from PR #305

@timur-harin timur-harin mentioned this pull request May 15, 2024
@yegor256
Copy link
Owner

@timur-harin why the check is not catching these errors? Maybe we should also fix the check, in this PR?

@timur-harin
Copy link
Contributor Author

timur-harin commented May 15, 2024

@yegor256
Could I make it in separate PR?

Because you told us:
"My recommendation to you: make smaller PRs! Think about their total count, not about their value"

@yegor256
Copy link
Owner

@timur-harin that's correct, but this PR doesn't make sense: we don't fix the problem.

@timur-harin
Copy link
Contributor Author

@yegor256
I solved this issue, it was because .java and .xml files were not in search by extensions
Now I added them and also avoid these folders:

  • test-zone - because here are not source code files
  • unparseable - because you are not the author of java files inside

@yegor256 yegor256 merged commit 1e745f2 into yegor256:master May 19, 2024
9 checks passed
@yegor256
Copy link
Owner

@timur-harin thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants