Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brew for main packages install from macos #337

Merged
merged 8 commits into from
May 24, 2024

Conversation

timur-harin
Copy link
Contributor

@yegor256
In this pull request, I have added:

  • Check for macOS system
  • Check and installation of brew if not installed
  • Install steps using brew in steps/install.sh

@yegor256
Copy link
Owner

@timur-harin don't you think that installing homebrew to an innocent user's machine is a bit intrusive? :) They clone our repo, run make install and then boom! -- their system has a new system-level component. I think, they will be surprised at best.

@timur-harin
Copy link
Contributor Author

@yegor256
I agree. So we can make echo message, that if brew not installed you can download it and put install link?

@yegor256
Copy link
Owner

@timur-harin yes, this will be reasonable. We either 1) use brew install ... if brew is present, or 2) we say "if you install Homebrew, all necessary packages will be installed automatically by make install"

@timur-harin
Copy link
Contributor Author

@yegor256
I updated this PR:

  • Now it will not install brew, only suggest if not found

@timur-harin timur-harin mentioned this pull request May 24, 2024
@yegor256 yegor256 merged commit 4dbde38 into yegor256:master May 24, 2024
10 checks passed
@yegor256
Copy link
Owner

@timur-harin thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants