Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macos runner #342

Merged
merged 26 commits into from
May 27, 2024
Merged

Add macos runner #342

merged 26 commits into from
May 27, 2024

Conversation

timur-harin
Copy link
Contributor

@yegor256
In this PR, I added:

  • macos-12 runner

Let's see if all will be fine, but because it will run container...

@timur-harin
Copy link
Contributor Author

@yegor256
I see from documentation that macOS runners do not support container job

Could I create a separate job for macOS to test sudo make install?

Screenshot 2024-05-24 at 15 04 32

@timur-harin
Copy link
Contributor Author

timur-harin commented May 24, 2024

@yegor256
I created another job for macos only, to check it we need to merge PR #337 and PR #339

@yegor256
Copy link
Owner

@timur-harin
Copy link
Contributor Author

@yegor256
As you see in this commit, I already tried, problem is in container job

@timur-harin
Copy link
Contributor Author

@yegor256 I see from documentation that macOS runners do not support container job

Could I create a separate job for macOS to test sudo make install?

Screenshot 2024-05-24 at 15 04 32

@yegor256
Please see again

@timur-harin
Copy link
Contributor Author

@yegor256
Oh, yes!
Now all is done!

In this separate job for macOS with make install:

  • we should use make install, not docker, because macOS runners could not use containerized jobs
  • should use make install without sudo, because homebrew should use without root, if no
Error: Running Homebrew as root is extremely dangerous and no longer supported. As Homebrew does not drop privileges on installation you would be giving all build scripts full access to your system.
 
  • in macOS JPEEK installed in /opt/app/jpeek.jar, so we need sudo to mkdir and mv

But this job takes a lot, will you manage to run this job only when you need?

To make this job works with current source code for make test - it will take a lot

@timur-harin
Copy link
Contributor Author

@yegor256 please check

@yegor256 yegor256 merged commit d9a51b6 into yegor256:master May 27, 2024
11 checks passed
@yegor256
Copy link
Owner

@timur-harin good work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants