Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

measure.sh and measure-file.sh description inside metrics/README.md #343

Merged
merged 7 commits into from
May 27, 2024

Conversation

IlnurHA
Copy link
Contributor

@IlnurHA IlnurHA commented May 26, 2024

Readme file update as requested in this comment for the issue for better understanding of steps/measure.sh and steps/measure-file.sh inside make process and better contribution in the future

@IlnurHA
Copy link
Contributor Author

IlnurHA commented May 26, 2024

@yegor256 Please check if this fits necessary requirements


## Metrics in make

Metrics could be calculated in **measure** step presented in makefile.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IlnurHA why it's "makefile" instead of Makefile?


## Metrics in make

Metrics could be calculated in **measure** step presented in makefile.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IlnurHA try to avoid bold and italic in tech documents, see: https://www.yegor256.com/2019/05/21/dont-improvise.html

* Creating necessary files and directories
* Collecting jobs to execute in parallel
(Currently, one for each java file to analyze metrics for)
* Executes jobs using `help/parallel.sh`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IlnurHA why it's creating, collecting and then all of a sudden executes? Set the time of the verbs straight

@yegor256
Copy link
Owner

@IlnurHA thanks! The text looks pretty dirty now, please, see the comments above. There are more problems, I hope you can find and fix them yourself.

@IlnurHA
Copy link
Contributor Author

IlnurHA commented May 26, 2024

@yegor256 fixed what you asked. Please, check if it is suitable now

@@ -25,3 +27,33 @@ the name of the metric. The second one contains the value (float or integer).
The third one contains the description of the metric (in general, NOT
for this particular file). A space is mandatory between the first and the
second column, and between the second and the third columns.

## Metrics in make
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IlnurHA the title doesn't sound right


## Metrics in make

Metrics could be calculated in measure step presented in `Makefile`.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IlnurHA in "the measure" step

@yegor256
Copy link
Owner

@IlnurHA try to use ChatGPT to clean up the grammar, now it sounds pretty wrong

@IlnurHA
Copy link
Contributor Author

IlnurHA commented May 27, 2024

@yegor256. Please check the description. Hopefully, it is in a better condition now

@yegor256 yegor256 merged commit fde84b3 into yegor256:master May 27, 2024
10 checks passed
@yegor256
Copy link
Owner

@IlnurHA thanks!

@IlnurHA IlnurHA deleted the metrics-README branch May 27, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants