Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency rubocop-rspec to v2.25.0 #15

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 9, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rubocop-rspec (changelog) '2.23.0' -> '2.25.0' age adoption passing confidence

Release Notes

rubocop/rubocop-rspec (rubocop-rspec)

v2.25.0

Compare Source

  • Add support single quoted string and percent string and heredoc for RSpec/Rails/HttpStatus. ([@​ydah])
  • Change to be inline disable for RSpec/SpecFilePathFormat like RSpec/FilePath. ([@​ydah])
  • Fix a false positive for RSpec/MetadataStyle with example groups having multiple string arguments. ([@​franzliedke])

v2.24.1

Compare Source

  • Fix an error when using RSpec/FilePath and revert to enabled by default. If you have already moved to RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat, disable RSpec/FilePath explicitly as Enabled: false. The RSpec/FilePath before migration and the RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat as the target are available respectively. ([@​ydah])

v2.24.0

Compare Source

  • Split RSpec/FilePath into RSpec/SpecFilePathSuffix and RSpec/SpecFilePathFormat. RSpec/FilePath cop is disabled by default and the two new cops are pending and need to be enabled explicitly. ([@​ydah])
  • Add new RSpec/Eq cop. ([@​ydah])
  • Add RSpec/MetadataStyle and RSpec/EmptyMetadata cops. ([@​r7kamura])
  • Add support RSpec/Rails/HttpStatus when have_http_status with string argument. ([@​ydah])
  • Fix an infinite loop error when RSpec/ExcessiveDocstringSpacing finds a description with non-ASCII leading/trailing whitespace. ([@​bcgraham])
  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when return values declared between stubs. ([@​marocchino])
  • Fix a false positive RSpec/Focus when chained method call and inside define method. ([@​ydah])

v2.23.2

Compare Source

  • Fix an incorrect autocorrect for RSpec/ReceiveMessages when method is only non-word character. ([@​marocchino])
  • Fix a false positive for RSpec/ReceiveMessages when return with splat. ([@​marocchino])

v2.23.1

Compare Source

  • Mark to Safe: false for RSpec/Rails/NegationBeValid cop. ([@​ydah])
  • Declare autocorrect as unsafe for RSpec/ReceiveMessages. ([@​bquorning])

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@yegor256
Copy link
Owner

yegor256 commented Aug 9, 2023

@rultor please, try to merge, since 5 checks have passed

@rultor
Copy link
Collaborator

rultor commented Aug 9, 2023

@rultor please, try to merge, since 5 checks have passed

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Aug 9, 2023

@rultor please, try to merge, since 5 checks have passed

@renovate[bot] @yegor256 Oops, I failed. You can see the full log here (spent 7min)

    \u001b[32mGiven I have a "\u001b[32m\u001b[1m.fief\u001b[0m\u001b[0m\u001b[32m" file with content:\u001b[90m # features/step_definitions/steps.rb:41\u001b[0m\u001b[0m
\u001b[32m      """\u001b[0m
\u001b[32m      --verbose\u001b[0m
\u001b[32m\u001b[0m
\u001b[32m      --include=yegor256/fief\u001b[0m
\u001b[32m      """\u001b[0m
To use retry middleware with Faraday v2.0+, install `faraday-retry` gem
    \u001b[32mWhen I run bin/fief with "\u001b[32m\u001b[1m--dry\u001b[0m\u001b[0m\u001b[32m"\u001b[90m          # features/step_definitions/steps.rb:46\u001b[0m\u001b[0m
    \u001b[32mThen Stdout contains "\u001b[32m\u001b[1mXML saved to\u001b[0m\u001b[0m\u001b[32m"\u001b[90m       # features/step_definitions/steps.rb:52\u001b[0m\u001b[0m
    \u001b[32mAnd Exit code is zero\u001b[90m                     # features/step_definitions/steps.rb:60\u001b[0m\u001b[0m

Feature: Gem Package
  As a source code writer I want to be able to
  package the Gem into .gem file

  Scenario: Gem can be packaged                  \u001b[90m# features/gem_package.feature:5\u001b[0m
    \u001b[32mGiven I have a "\u001b[32m\u001b[1mexecs.rb\u001b[0m\u001b[0m\u001b[32m" file with content:\u001b[90m # features/step_definitions/steps.rb:41\u001b[0m\u001b[0m
\u001b[32m      """\u001b[0m
\u001b[32m      #!/usr/bin/env ruby\u001b[0m
\u001b[32m      require 'rubygems'\u001b[0m
\u001b[32m      spec = Gem::Specification::load('./spec.rb')\u001b[0m
\u001b[32m      if spec.executables.empty?\u001b[0m
\u001b[32m        fail 'no executables: ' + File.read('./spec.rb')\u001b[0m
\u001b[32m      end\u001b[0m
\u001b[32m      """\u001b[0m
/tmp/test20230809-1424-5sllij/fief/lib/fief/version.rb:26: warning: already initialized constant Fief::VERSION
/home/r/repo/lib/fief/version.rb:26: warning: previous definition of VERSION was here
    \u001b[32mWhen I run bash with:\u001b[90m                        # features/step_definitions/steps.rb:74\u001b[0m\u001b[0m
\u001b[32m      """\u001b[0m
\u001b[32m      cd fief\u001b[0m
\u001b[32m      gem build fief.gemspec\u001b[0m
\u001b[32m      gem specification --ruby fief-*.gem > ../spec.rb\u001b[0m
\u001b[32m      cd ..\u001b[0m
\u001b[32m      ruby execs.rb\u001b[0m
\u001b[32m      """\u001b[0m
    \u001b[32mThen Exit code is zero\u001b[90m                       # features/step_definitions/steps.rb:60\u001b[0m\u001b[0m

\u001b[31mFailing Scenarios:\u001b[0m
\u001b[31mcucumber features/cli.feature:18\u001b[0m\u001b[90m # Scenario: Simple report through real GitHub API\u001b[0m

6 scenarios (\u001b[31m1 failed\u001b[0m, \u001b[32m5 passed\u001b[0m)
18 steps (\u001b[31m1 failed\u001b[0m, \u001b[36m1 skipped\u001b[0m, \u001b[32m16 passed\u001b[0m)
0m35.289s
\u001b[1m\u001b[32m┌──────────────────────────────────────────────────────────────────────────────┐\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m Share your Cucumber Report with your team at \u001b[4m\u001b[1m\u001b[36mhttps://reports.cucumber.io\u001b[0m\u001b[0m\u001b[0m     \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m                                                                              \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m Command line option:    \u001b[36m--publish\u001b[0m                                            \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m Environment variable:   \u001b[36mCUCUMBER_PUBLISH_ENABLED\u001b[0m=\u001b[36mtrue\u001b[0m                        \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m cucumber.yml:           \u001b[36mdefault: --publish\u001b[0m                                   \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m                                                                              \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m More information at \u001b[4m\u001b[1m\u001b[36mhttps://cucumber.io/docs/cucumber/environment-variables/\u001b[0m\u001b[0m\u001b[0m \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m                                                                              \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m To disable this message, specify \u001b[1mCUCUMBER_PUBLISH_QUIET=true\u001b[0m or use the      \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m \u001b[1m--publish-quiet\u001b[0m option. You can also add this to your \u001b[1mcucumber.yml:\u001b[0m          \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m \u001b[1mdefault: --publish-quiet\u001b[0m                                                     \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m└──────────────────────────────────────────────────────────────────────────────┘\u001b[0m\u001b[0m
Coverage report generated for Cucumber Features, Unit Tests to /home/r/repo/coverage. 12 / 59 LOC (20.34%) covered.
Stopped processing SimpleCov as a previous error not related to SimpleCov has been detected
container 984843f2a9bb0fc639d848fe24b9b3eea06091bdffbf38923db26612bd3daf92 is dead
Wed 09 Aug 2023 07:00:34 PM CEST

@renovate renovate bot changed the title Update dependency rubocop-rspec to v2.23.2 Update dependency rubocop-rspec to v2.24.0 Sep 23, 2023
@renovate renovate bot force-pushed the renovate/rubocop-rspec-2.x branch from 9546157 to 84d93df Compare September 23, 2023 15:58
@renovate renovate bot force-pushed the renovate/rubocop-rspec-2.x branch from 84d93df to 4d206f7 Compare October 27, 2023 09:40
@renovate renovate bot changed the title Update dependency rubocop-rspec to v2.24.0 Update dependency rubocop-rspec to v2.25.0 Oct 27, 2023
@yegor256
Copy link
Owner

yegor256 commented Nov 9, 2023

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Nov 9, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented Nov 9, 2023

@rultor merge

@renovate[bot] @yegor256 Oops, I failed. You can see the full log here (spent 4min)

    \u001b[32mGiven I have a "\u001b[32m\u001b[1mexecs.rb\u001b[0m\u001b[0m\u001b[32m" file with content:\u001b[90m # features/step_definitions/steps.rb:41\u001b[0m\u001b[0m
\u001b[32m      """\u001b[0m
\u001b[32m      #!/usr/bin/env ruby\u001b[0m
\u001b[32m      require 'rubygems'\u001b[0m
\u001b[32m      spec = Gem::Specification::load('./spec.rb')\u001b[0m
\u001b[32m      if spec.executables.empty?\u001b[0m
\u001b[32m        fail 'no executables: ' + File.read('./spec.rb')\u001b[0m
\u001b[32m      end\u001b[0m
\u001b[32m      """\u001b[0m
/tmp/test20231109-1416-4dolqv/fief/lib/fief/version.rb:26: warning: already initialized constant Fief::VERSION
/home/r/repo/lib/fief/version.rb:26: warning: previous definition of VERSION was here
    \u001b[32mWhen I run bash with:\u001b[90m                        # features/step_definitions/steps.rb:74\u001b[0m\u001b[0m
\u001b[32m      """\u001b[0m
\u001b[32m      cd fief\u001b[0m
\u001b[32m      gem build fief.gemspec\u001b[0m
\u001b[32m      gem specification --ruby fief-*.gem > ../spec.rb\u001b[0m
\u001b[32m      cd ..\u001b[0m
\u001b[32m      ruby execs.rb\u001b[0m
\u001b[32m      """\u001b[0m
    \u001b[32mThen Exit code is zero\u001b[90m                       # features/step_definitions/steps.rb:60\u001b[0m\u001b[0m

6 scenarios (\u001b[32m6 passed\u001b[0m)
18 steps (\u001b[32m18 passed\u001b[0m)
0m47.656s
\u001b[1m\u001b[32m┌──────────────────────────────────────────────────────────────────────────────┐\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m Share your Cucumber Report with your team at \u001b[4m\u001b[1m\u001b[36mhttps://reports.cucumber.io\u001b[0m\u001b[0m\u001b[0m     \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m                                                                              \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m Command line option:    \u001b[36m--publish\u001b[0m                                            \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m Environment variable:   \u001b[36mCUCUMBER_PUBLISH_ENABLED\u001b[0m=\u001b[36mtrue\u001b[0m                        \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m cucumber.yml:           \u001b[36mdefault: --publish\u001b[0m                                   \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m                                                                              \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m More information at \u001b[4m\u001b[1m\u001b[36mhttps://cucumber.io/docs/cucumber/environment-variables/\u001b[0m\u001b[0m\u001b[0m \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m                                                                              \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m To disable this message, specify \u001b[1mCUCUMBER_PUBLISH_QUIET=true\u001b[0m or use the      \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m \u001b[1m--publish-quiet\u001b[0m option. You can also add this to your \u001b[1mcucumber.yml:\u001b[0m          \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m│\u001b[0m\u001b[0m \u001b[1mdefault: --publish-quiet\u001b[0m                                                     \u001b[1m\u001b[32m│\u001b[0m\u001b[0m
\u001b[1m\u001b[32m└──────────────────────────────────────────────────────────────────────────────┘\u001b[0m\u001b[0m
Coverage report generated for Cucumber Features, Unit Tests to /home/r/repo/coverage. 12 / 59 LOC (20.34%) covered.
Running RuboCop...
Inspecting 20 files
\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m\u001b[32m.\u001b[0m

20 files inspected, \u001b[32mno offenses\u001b[0m detected
Running xcop...
Inspecting 1 file...
\u001b[32m.\u001b[0m
1 file checked, everything looks \u001b[32mpretty\u001b[0m
grep -q -r '2023'     --include '*.rb'     --include '*.txt'     --include 'Rakefile'     .
+ mv /home/r/repo .
++ whoami
+ chown -R root repo
+ '[' -n '' ']'
++ whoami
+ sudo chown -R rultor repo
+ cd repo
+ git push origin master
send-pack: unexpected disconnect while reading sideband packet
fatal: the remote end hung up unexpectedly
container 00e2eb2603e98428da9ab801ab8351bf513bc091fb56a8236e7ea7ece69d70db is dead
Thu Nov  9 12:40:03 PM CET 2023

@yegor256
Copy link
Owner

yegor256 commented Nov 9, 2023

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Nov 9, 2023

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 2cc3d36 into master Nov 9, 2023
5 checks passed
@renovate renovate bot deleted the renovate/rubocop-rspec-2.x branch November 9, 2023 11:53
@rultor
Copy link
Collaborator

rultor commented Nov 9, 2023

@rultor merge

@yegor256 Done! FYI, the full log is here (took me 4min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants