feat(#5): Add java and javac methods to Jhome
#6
Conversation
|
@yegor256 Could you take a look, please? |
|
@volodya-lombrozo in case of Java8 it's JRE, not JDK |
|
@yegor256 Take a look one more time, please |
| * @return The path of it | ||
| */ | ||
| public Path java() { | ||
| return this.home.resolve("bin").resolve("java"); |
There was a problem hiding this comment.
@volodya-lombrozo looks like code duplication to me. It's better to call path("bin/java") from here
| * {@code Optional<Path>} is also a solution here. | ||
| */ | ||
| public Path javac() { | ||
| return this.home.resolve("bin").resolve("javac"); |
There was a problem hiding this comment.
@volodya-lombrozo same here, looks like code duplication
|
@volodya-lombrozo I made it work on Windows (see the changes in the test). Would be great if in your pull request you also update README and explain that calling |
|
@yegor256 Updated the PR according with your suggestions. Could you take a look one more time please? |
|
@volodya-lombrozo the tests don't pass on windows ( |
|
@yegor256 I fixed the problem with the Windows OS. Could you take a look, please? |
|
@rultor merge |
Add
javaandjavacmethods toJhome.Closes: #5.