Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different line length limit for groovy and java files #867

Closed
g4s8 opened this issue Feb 12, 2018 · 15 comments
Closed

Different line length limit for groovy and java files #867

g4s8 opened this issue Feb 12, 2018 · 15 comments
Assignees

Comments

@g4s8
Copy link

g4s8 commented Feb 12, 2018

It's not clear why line length limit for groovy and java files is different:

  • java - 80 chars
  • groovy - 120 chars

I think 120 chars would be OK for all file-type.

@0crat
Copy link
Collaborator

0crat commented Feb 12, 2018

@krzyk/z please, pay attention to this issue

@krzyk
Copy link
Collaborator

krzyk commented Nov 21, 2018

@g4s8 I missed that, but there was already a discussion about this here - #862

@yegor256 Should groovy files be limited to 80 chars also? Or are we leaving them at 120 chars, because we assume there will be less code in groovy and more with "script" nature?

@yegor256
Copy link
Owner

@krzyk do we still check Groovy files in Qulice? We shouldn't. As for the Java, I would suggest to migrate to 100 chars limit. 80 is indeed too narrow.. WDYT?

@krzyk
Copy link
Collaborator

krzyk commented Dec 25, 2018

@yegor256 We check only java files for line length. OK so let's go with 100 chars for java. @g4s8 could you update your comment?
Groovy is checked using codenarc and not using qulice and we will increase java limit to 100 chars.

@krzyk
Copy link
Collaborator

krzyk commented Dec 25, 2018

@0crat in

@0crat 0crat added the scope label Dec 25, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 25, 2018

@0crat in (here)

@krzyk Job #867 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Dec 25, 2018

Bug was reported, see §29: +15 point(s) just awarded to @g4s8/z

@krzyk
Copy link
Collaborator

krzyk commented Dec 27, 2018

@0crat assign me

krzyk added a commit to krzyk/qulice that referenced this issue Dec 27, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 27, 2018

@0crat assign me (here)

@krzyk The job #867 assigned to @krzyk/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Dec 27, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @krzyk/z

krzyk added a commit to krzyk/qulice that referenced this issue Dec 27, 2018
@krzyk
Copy link
Collaborator

krzyk commented Dec 27, 2018

@g4s8 change has been merged to master and will be released in 0.18.9 in hour or two, please close this issue

@g4s8
Copy link
Author

g4s8 commented Dec 28, 2018

@krzyk thanks

@g4s8 g4s8 closed this as completed Dec 28, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 28, 2018

Job was finished in 22 hours, bonus for fast delivery is possible (see §36)

@0crat 0crat removed the scope label Dec 28, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 28, 2018

The job #867 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Dec 28, 2018

Order was finished: +35 point(s) just awarded to @krzyk/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants