#950 Updated How Rultor Works #991

gumbelmj · 2016-01-26T01:05:46Z

Updated the Readme. Some checks failed. Do I need to be concerned about these?

alex-palevsky · 2016-01-26T14:12:21Z

@gumbelmj Thanks for your pull request, let me find someone who can review it

alex-palevsky · 2016-01-26T14:17:26Z

@caarlos0 review this please

caarlos0 · 2016-01-26T14:48:14Z

README.md

+<li>Reports back to you, in the GitHub pull request.</li>
+</ol>
+You can see it in action, for example, in this pull request: 
+<a href="https://github.com/jcabi/jcabi-github/pull/878">jcabi/jcabi-github#878</a>.


@gumbelmj this is a markdown file, please, use markdown syntax.

caarlos0 · 2016-01-26T14:48:59Z

@gumbelmj no need to be concerned about the failed checks, I already opened issues for them: #993 and #722

caarlos0 · 2016-01-26T14:49:10Z

@gumbelmj please see my comment above

gumbelmj · 2016-01-27T21:32:18Z

I updated the pull request, but even MORE tests failed? Is that my issue? And if so, what's wrong?

caarlos0 · 2016-01-27T21:46:25Z

@gumbelmj thanks!

caarlos0 · 2016-01-27T21:46:28Z

@rultor merge

rultor · 2016-01-27T21:47:29Z

@rultor merge

@caarlos0 Thanks for your request. @yegor256 Please confirm this.

caarlos0 · 2016-01-28T23:09:47Z

@yegor256 ping

yegor256 · 2016-01-29T00:15:13Z

@rultor merge

rultor · 2016-01-29T00:59:43Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2016-01-29T01:02:13Z

@rultor merge

@gumbelmj @yegor256 Oops, I failed. You can see the full log here (spent 2min)

+ args=' --ff-only'
+ export BRANCH=__rultor
+ BRANCH=__rultor
++ git show-branch __rultor
++ wc -l
+ '[' 0 -gt 0 ']'
+ git checkout fork/master
Note: checking out 'fork/master'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at c719973... #950 Update How Rultor works from HTML to Markdown
+ git checkout -b __rultor
Switched to a new branch '__rultor'
+ git checkout master
Switched to branch 'master'
+ '[' true == true ']'
+ git checkout __rultor
Switched to branch '__rultor'
+ git rebase master
First, rewinding head to replay your work on top of it...
Applying: 950 Updated How Rultor Works
Applying: #950 Update How Rultor works from HTML to Markdown
+ git checkout master
Switched to branch 'master'
+ '[' false == true ']'
+ git merge --ff-only __rultor
Updating 51fb2df..7a4786f
Fast-forward
 README.md | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)
+ docker_when_possible
+ true
++ uptime
++ sed 's/ /\n/g'
++ tail -n 1
+ load=0.02
++ echo 0.02 '>' 30
++ bc
+ '[' 0 -eq 1 ']'
+ echo 'load average is 0.02, low enough to run a new Docker container'
load average is 0.02, low enough to run a new Docker container
+ break
+ cd ..
+ '[' -n '' ']'
+ use_image=yegor256/rultor
+ docker pull yegor256/rultor
Using default tag: latest
Post http:///var/run/docker.sock/v1.20/images/create?fromImage=yegor256%2Frultor%3Alatest: dial unix /var/run/docker.sock: no such file or directory.
* Are you trying to connect to a TLS-enabled daemon without TLS?
* Is your docker daemon up and running?
'cid' file is absent, container wasn't started correctly

yegor256 · 2016-01-29T01:24:29Z

@rultor merge

rultor · 2016-01-29T01:24:58Z

@rultor merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2016-01-29T01:40:06Z

@rultor merge

@gumbelmj @yegor256 Oops, I failed. You can see the full log here (spent 15min)

    from /usr/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:69:in `require'
    from /usr/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:69:in `require'
    from /var/lib/gems/2.2.0/gems/safe_yaml-1.0.4/lib/safe_yaml/load.rb:131:in `<module:SafeYAML>'
    from /var/lib/gems/2.2.0/gems/safe_yaml-1.0.4/lib/safe_yaml/load.rb:26:in `<top (required)>'
    from /usr/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:121:in `require'
    from /usr/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:121:in `require'
    from /var/lib/gems/2.2.0/gems/jekyll-3.1.0/lib/jekyll.rb:28:in `<top (required)>'
    from /usr/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:69:in `require'
    from /usr/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:69:in `require'
    from /var/lib/gems/2.2.0/gems/jekyll-3.1.0/bin/jekyll:6:in `<top (required)>'
    from /usr/local/bin/jekyll:23:in `load'
    from /usr/local/bin/jekyll:23:in `<main>'
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.247 s
[INFO] Finished at: 2016-01-29T01:39:27+00:00
[INFO] Final Memory: 16M/276M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.4.0:exec (jekyll-build) on project rultor: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.4.0:exec (jekyll-build) on project rultor: Command execution failed.
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:108)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:76)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:116)
    at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:361)
    at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
    at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
    at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:213)
    at org.apache.maven.cli.MavenCli.main(MavenCli.java:157)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:606)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Command execution failed.
    at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:276)
    at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:133)
    at org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
    ... 19 more
Caused by: org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1)
    at org.apache.commons.exec.DefaultExecutor.executeInternal(DefaultExecutor.java:404)
    at org.apache.commons.exec.DefaultExecutor.execute(DefaultExecutor.java:166)
    at org.codehaus.mojo.exec.ExecMojo.executeCommandLine(ExecMojo.java:660)
    at org.codehaus.mojo.exec.ExecMojo.execute(ExecMojo.java:265)
    ... 21 more
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
container 13b21f61902081ccf00b2c1bc60fe67350d8d2d80f9a2a9164616bea13f47c63 is dead
Fri Jan 29 01:40:02 UTC 2016

caarlos0 · 2016-01-29T12:34:33Z

README.md

@@ -26,15 +26,27 @@ TBD... _product statement_

 ## What Problem Does Rultor Solve?

-TBD... _stakeholders and needs_
+TBD... _stakeholders and need


@gumbelmj you are missing the closing _ at the end of the line here...

gumbelmj · 2016-01-29T12:46:56Z

@caarlos0 Doh! I missed that it even changed. Thanks. I fixed it.

caarlos0 · 2016-01-31T14:36:31Z

@yegor256 can we try again?

yegor256 · 2016-02-12T22:26:57Z

@rultor try to merge

rultor · 2016-02-12T22:28:24Z

@rultor try to merge

@yegor256 OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2016-02-12T22:40:50Z

@rultor try to merge

@yegor256 Done! FYI, the full log is here (took me 12min)

Closes #997 Also pluralized "Problem" as Rultor solves more than a single problem. Wrote paragraphs instead of a enumeration so that the README looks more like thorough documentation and less like a TODO list.

…delimited by comma, by using regex for #821

…e mention being preceeded by a comma for #821

caarlos0 · 2016-02-14T14:02:57Z

@yegor256 rultor is strange here... it says it merged the pull, but looks like it didn't

caarlos0 · 2016-02-15T22:21:41Z

@gumbelmj merge conflicts

* Created new ShellCommand class to encapsulated running a command in a shell * Used ShellCommand to make EndsDaemon use fewer objects and remove duplicate logic for sanitizing and running commands in EndsDaemon

gumbelmj · 2016-02-16T23:59:03Z

@caarlos0 I believe I fixed the merge conflicts.

caarlos0 · 2016-02-17T01:53:54Z

@rultor merge

rultor · 2016-02-17T01:54:08Z

@rultor merge

@caarlos0 Thanks for your request. @yegor256 Please confirm this.

original-brownbear · 2016-02-20T21:35:35Z

@gumbelmj @caarlos0 even though the team file is not yet updated, but by the power vested in me ...

This should not be merged! The ticket asks for the readme file to be updated, this PR changes 14 files and would break the build anyhow and not pass(messes up the Jekyll gemset).
The merge conflicts were not resolved correctly and from the looks of it this branch is pretty much beyond repair.
Also see #935, your branch is called master, so this bug will prevent a merge either way.
@gumbelmj I would suggest to create a new branch from current master, call it 950 like the issue it is resolving and then simply make your edits to the readme file in one commit and put in a new PR.
This one can be closed I think.

caarlos0 · 2016-02-21T00:31:50Z

@original-brownbear makes sense, seems like a wrong merge...

gumbelmj · 2016-02-21T17:06:36Z

@caarlos0 I'm closing this pull request and I will open a new one to resolve this issue.

alex-palevsky · 2016-02-25T16:50:40Z

@caarlos0 10 mins added to @original-brownbear account (our architect), payment ID is AP-4JA624692F077145S, since quality is good here

gumbelmj and others added 3 commits January 25, 2016 19:53

950 Updated How Rultor Works

0fe6cd1

#988 two sizes for button

b361cf2

deploy

008f8da

TEAM.md page updated

51fb2df

alex-palevsky added CR labels Jan 26, 2016

caarlos0 reviewed Jan 26, 2016
View reviewed changes

#950 Update How Rultor works from HTML to Markdown

c719973

caarlos0 reviewed Jan 29, 2016
View reviewed changes

gumbelmj added 2 commits January 29, 2016 07:44

#950 add a missing underscore

61bba75

#950 correct grammar

1cb9494

TEAM.md page updated

a6f518d

fixing site target by running jekyll in bundle context, see #1001

531d3ae

gumbelmj added 5 commits February 12, 2016 22:29

950 Updated How Rultor Works

52a529a

#950 Update How Rultor works from HTML to Markdown

ff848c0

#950 add a missing underscore

5f7162d

#950 correct grammar

ba8decd

#950 Updated readme example

94cf184

Bernardo and others added 7 commits February 12, 2016 22:43

README should have what problems Rultor solves

8780a5b

Closes #997 Also pluralized "Problem" as Rultor solves more than a single problem. Wrote paragraphs instead of a enumeration so that the README looks more like thorough documentation and less like a TODO list.

Updated README section according to feedback

ea19515

README should also mention pre-flight builds

e7632d9

fixed Rultor login prefix not recognized correctly in comments, when …

5ea498f

…delimited by comma, by using regex for #821

fixed regular expression, jdoc and added additional tests for #821

78940a5

fixed regular expression and added additional test for the case of th…

f57bef8

…e mention being preceeded by a comma for #821

fixed indention and missing javadoc on long regex for #821

9aef851

original-brownbear and others added 3 commits February 16, 2016 03:33

\#934 Refactored EndsDaemon to use ShellCommand

77be2ed

* Created new ShellCommand class to encapsulated running a command in a shell * Used ShellCommand to make EndsDaemon use fewer objects and remove duplicate logic for sanitizing and running commands in EndsDaemon

#934 corrected version in com.rultor.agents.daemons.ShellCommand

c0647b9

Merge branch 'master' of https://github.com/gumbelmj/rultor

c3234e6

gumbelmj closed this Feb 21, 2016

gumbelmj mentioned this pull request Feb 22, 2016

#950 Reverting How Rultor Works #1012

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#950 Updated How Rultor Works #991

#950 Updated How Rultor Works #991

gumbelmj commented Jan 26, 2016

alex-palevsky commented Jan 26, 2016

alex-palevsky commented Jan 26, 2016

caarlos0 Jan 26, 2016

caarlos0 commented Jan 26, 2016

caarlos0 commented Jan 26, 2016

gumbelmj commented Jan 27, 2016

caarlos0 commented Jan 27, 2016

caarlos0 commented Jan 27, 2016

rultor commented Jan 27, 2016

caarlos0 commented Jan 28, 2016

yegor256 commented Jan 29, 2016

rultor commented Jan 29, 2016

rultor commented Jan 29, 2016

yegor256 commented Jan 29, 2016

rultor commented Jan 29, 2016

rultor commented Jan 29, 2016

caarlos0 Jan 29, 2016

gumbelmj commented Jan 29, 2016

caarlos0 commented Jan 31, 2016

yegor256 commented Feb 12, 2016

rultor commented Feb 12, 2016

rultor commented Feb 12, 2016

caarlos0 commented Feb 14, 2016

caarlos0 commented Feb 15, 2016

gumbelmj commented Feb 16, 2016

caarlos0 commented Feb 17, 2016

rultor commented Feb 17, 2016

original-brownbear commented Feb 20, 2016

caarlos0 commented Feb 21, 2016

gumbelmj commented Feb 21, 2016

alex-palevsky commented Feb 25, 2016

#950 Updated How Rultor Works #991

#950 Updated How Rultor Works #991

Conversation

gumbelmj commented Jan 26, 2016

alex-palevsky commented Jan 26, 2016

alex-palevsky commented Jan 26, 2016

caarlos0 Jan 26, 2016

Choose a reason for hiding this comment

caarlos0 commented Jan 26, 2016

caarlos0 commented Jan 26, 2016

gumbelmj commented Jan 27, 2016

caarlos0 commented Jan 27, 2016

caarlos0 commented Jan 27, 2016

rultor commented Jan 27, 2016

caarlos0 commented Jan 28, 2016

yegor256 commented Jan 29, 2016

rultor commented Jan 29, 2016

rultor commented Jan 29, 2016

yegor256 commented Jan 29, 2016

rultor commented Jan 29, 2016

rultor commented Jan 29, 2016

caarlos0 Jan 29, 2016

Choose a reason for hiding this comment

gumbelmj commented Jan 29, 2016

caarlos0 commented Jan 31, 2016

yegor256 commented Feb 12, 2016

rultor commented Feb 12, 2016

rultor commented Feb 12, 2016

caarlos0 commented Feb 14, 2016

caarlos0 commented Feb 15, 2016

gumbelmj commented Feb 16, 2016

caarlos0 commented Feb 17, 2016

rultor commented Feb 17, 2016

original-brownbear commented Feb 20, 2016

caarlos0 commented Feb 21, 2016

gumbelmj commented Feb 21, 2016

alex-palevsky commented Feb 25, 2016