Improper CSS file inclusion technique #62

smartclash · 2017-04-12T05:27:11Z

Hi,

I just came across your project and I find it a very good idea. The only problem is that you are violating the rules of GitHub. As per the github norms, we should directly include the CSS files to our project. But many still didn't obey.

To tackle this issue, GitHub served all the CSS files directly liked with header Content-Type: text/plain. So many modern browsers will understand it and will assume the CSS file to be a regular text file and thus, the whole page looks like a Ugly 1980's page.

So, a great person named Ryan Grove created a service called RawGit which serves all the content with proper Content-Type headers so that browsers behave well. And as a plus feature, the production URL in the RawGit gets routed through MaxCDN to make it blazing fast.

The main objective of this issue is to make you aware that you SHOULD NOT promote people to use this type of method. Instead there are many CDN providers which offer free CDN to open source project.

Check out :

The text was updated successfully, but these errors were encountered:

0crat · 2017-04-12T05:27:14Z

@yegor256 please, pay attention to this issue

yegor256 · 2017-04-25T15:24:56Z

@rultor release, tag is 0.8.1

rultor · 2017-04-25T15:26:03Z

@yegor256 OK, I will release it now. Please check the progress here

rultor · 2017-04-25T15:27:36Z

@smartclash @yegor256 Oops, I failed. You can see the full log here (spent 1min)

++ uptime
++ sed 's/ /\n/g'
++ tail -n 1
+ load=7.87
++ bc
++ echo 7.87 '>' 30
+ '[' 0 -eq 1 ']'
+ echo 'load average is 7.87, low enough to run a new Docker container'
load average is 7.87, low enough to run a new Docker container
+ break
+ cd ..
+ '[' -n '' ']'
+ use_image=yegor256/rultor
+ docker pull yegor256/rultor
Using default tag: latest
Trying to pull repository docker.io/yegor256/rultor ... latest: Pulling from yegor256/rultor
Digest: sha256:baeecb2546443131979b61998fd40a42a0ff0124c9d61fe07e957dcaf51ebfed
Status: Image is up to date for docker.io/yegor256/rultor:latest

+ docker ps --filter=status=exited
+ grep --quiet '\syegor256_tacit_62\s*$'
+ ls -al .
total 36
drwx------  3 rultor rultor   96 Apr 25 15:26 .
drwxrwxrwt. 9 root   root   4096 Apr 25 15:26 ..
-rwxrwxr-x  1 rultor rultor  326 Apr 25 15:26 entry.sh
-rw-rw-r--  1 rultor rultor    5 Apr 25 15:26 pid
drwxrwxr-x  4 rultor rultor 4096 Apr 25 15:26 repo
-rwxrwxr-x  1 rultor rultor 4941 Apr 25 15:26 run.sh
-rw-rw-r--  1 rultor rultor   98 Apr 25 15:26 s3cfg
-rw-rw-r--  1 rultor rultor  887 Apr 25 15:26 script.sh
-rw-rw-r--  1 rultor rultor 3806 Apr 25 15:26 stdout
++ pwd
++ pwd
+ docker run -t --rm -v /tmp/rultor-sxzv:/main --env=head=git@github.com:yegor256/tacit.git --env=head_branch=master --env=tag=0.8.1 --hostname=docker --privileged --memory=6g --memory-swap=16g --oom-kill-disable --cidfile=/tmp/rultor-sxzv/cid -w=/main --name=yegor256_tacit_62 yegor256/rultor /main/entry.sh
Usage of loopback devices is strongly discouraged for production use. Either use `--storage-opt dm.thinpooldev` or use `--storage-opt dm.no_warn_on_loop_devices=true` to suppress this warning.
+ set -e
+ set -o pipefail
+ shopt -s dotglob
+ useradd -m -G sudo r
+ echo '%sudo ALL=(ALL) NOPASSWD:ALL'
+ cp -R /root/.bashrc /root/.composer /root/.gem /root/.gnupg /root/.m2 /root/.npm /root/.profile /root/texmf /root/tmp /home/r
+ cp -R ./cid ./end.sh ./entry.sh ./pid ./repo ./run.sh ./s3cfg ./script.sh ./stdout /home/r
+ rm -rf repo
+ chown -R r:r /home/r
+ chmod a+x /home/r/script.sh
+ su -m r -c /home/r/script.sh
+ set -e
+ set -o pipefail
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ sudo gem install --no-ri pdd
Fetching: mini_portile2-2.1.0.gem
Fetching: mini_portile2-2.1.0.gem ( 87%)
Fetching: mini_portile2-2.1.0.gem (100%)
Fetching: mini_portile2-2.1.0.gem (100%)
Fetching: nokogiri-1.7.1.gem
Fetching: nokogiri-1.7.1.gem (  1%)
Fetching: nokogiri-1.7.1.gem (  2%)
Fetching: nokogiri-1.7.1.gem (  3%)
Fetching: nokogiri-1.7.1.gem (  4%)
Fetching: nokogiri-1.7.1.gem (  5%)
Fetching: nokogiri-1.7.1.gem (  6%)
Fetching: nokogiri-1.7.1.gem (  7%)
Fetching: nokogiri-1.7.1.gem (  8%)
Fetching: nokogiri-1.7.1.gem (  9%)
Fetching: nokogiri-1.7.1.gem ( 10%)
Fetching: nokogiri-1.7.1.gem ( 11%)
Fetching: nokogiri-1.7.1.gem ( 12%)
Fetching: nokogiri-1.7.1.gem ( 13%)
Fetching: nokogiri-1.7.1.gem ( 14%)
Fetching: nokogiri-1.7.1.gem ( 15%)
Fetching: nokogiri-1.7.1.gem ( 16%)
Fetching: nokogiri-1.7.1.gem ( 17%)
Fetching: nokogiri-1.7.1.gem ( 18%)
Fetching: nokogiri-1.7.1.gem ( 19%)
Fetching: nokogiri-1.7.1.gem ( 20%)
Fetching: nokogiri-1.7.1.gem ( 21%)
Fetching: nokogiri-1.7.1.gem ( 22%)
Fetching: nokogiri-1.7.1.gem ( 23%)
Fetching: nokogiri-1.7.1.gem ( 24%)
Fetching: nokogiri-1.7.1.gem ( 25%)
Fetching: nokogiri-1.7.1.gem ( 26%)
Fetching: nokogiri-1.7.1.gem ( 27%)
Fetching: nokogiri-1.7.1.gem ( 28%)
Fetching: nokogiri-1.7.1.gem ( 29%)
Fetching: nokogiri-1.7.1.gem ( 30%)
Fetching: nokogiri-1.7.1.gem ( 31%)
Fetching: nokogiri-1.7.1.gem ( 32%)
Fetching: nokogiri-1.7.1.gem ( 33%)
Fetching: nokogiri-1.7.1.gem ( 34%)
Fetching: nokogiri-1.7.1.gem ( 35%)
Fetching: nokogiri-1.7.1.gem ( 36%)
Fetching: nokogiri-1.7.1.gem ( 37%)
Fetching: nokogiri-1.7.1.gem ( 38%)
Fetching: nokogiri-1.7.1.gem ( 39%)
Fetching: nokogiri-1.7.1.gem ( 40%)
Fetching: nokogiri-1.7.1.gem ( 41%)
Fetching: nokogiri-1.7.1.gem ( 42%)
Fetching: nokogiri-1.7.1.gem ( 43%)
Fetching: nokogiri-1.7.1.gem ( 44%)
Fetching: nokogiri-1.7.1.gem ( 45%)
Fetching: nokogiri-1.7.1.gem ( 46%)
Fetching: nokogiri-1.7.1.gem ( 47%)
Fetching: nokogiri-1.7.1.gem ( 48%)
Fetching: nokogiri-1.7.1.gem ( 49%)
Fetching: nokogiri-1.7.1.gem ( 50%)
Fetching: nokogiri-1.7.1.gem ( 51%)
Fetching: nokogiri-1.7.1.gem ( 52%)
Fetching: nokogiri-1.7.1.gem ( 53%)
Fetching: nokogiri-1.7.1.gem ( 54%)
Fetching: nokogiri-1.7.1.gem ( 55%)
Fetching: nokogiri-1.7.1.gem ( 56%)
Fetching: nokogiri-1.7.1.gem ( 57%)
Fetching: nokogiri-1.7.1.gem ( 58%)
Fetching: nokogiri-1.7.1.gem ( 59%)
Fetching: nokogiri-1.7.1.gem ( 60%)
Fetching: nokogiri-1.7.1.gem ( 61%)
Fetching: nokogiri-1.7.1.gem ( 62%)
Fetching: nokogiri-1.7.1.gem ( 63%)
Fetching: nokogiri-1.7.1.gem ( 64%)
Fetching: nokogiri-1.7.1.gem ( 65%)
Fetching: nokogiri-1.7.1.gem ( 66%)
Fetching: nokogiri-1.7.1.gem ( 67%)
Fetching: nokogiri-1.7.1.gem ( 68%)
Fetching: nokogiri-1.7.1.gem ( 69%)
Fetching: nokogiri-1.7.1.gem ( 70%)
Fetching: nokogiri-1.7.1.gem ( 71%)
Fetching: nokogiri-1.7.1.gem ( 72%)
Fetching: nokogiri-1.7.1.gem ( 73%)
Fetching: nokogiri-1.7.1.gem ( 74%)
Fetching: nokogiri-1.7.1.gem ( 75%)
Fetching: nokogiri-1.7.1.gem ( 76%)
Fetching: nokogiri-1.7.1.gem ( 77%)
Fetching: nokogiri-1.7.1.gem ( 78%)
Fetching: nokogiri-1.7.1.gem ( 79%)
Fetching: nokogiri-1.7.1.gem ( 80%)
Fetching: nokogiri-1.7.1.gem ( 81%)
Fetching: nokogiri-1.7.1.gem ( 82%)
Fetching: nokogiri-1.7.1.gem ( 83%)
Fetching: nokogiri-1.7.1.gem ( 84%)
Fetching: nokogiri-1.7.1.gem ( 85%)
Fetching: nokogiri-1.7.1.gem ( 86%)
Fetching: nokogiri-1.7.1.gem ( 87%)
Fetching: nokogiri-1.7.1.gem ( 88%)
Fetching: nokogiri-1.7.1.gem ( 89%)
Fetching: nokogiri-1.7.1.gem ( 90%)
Fetching: nokogiri-1.7.1.gem ( 91%)
Fetching: nokogiri-1.7.1.gem ( 92%)
Fetching: nokogiri-1.7.1.gem ( 93%)
Fetching: nokogiri-1.7.1.gem ( 94%)
Fetching: nokogiri-1.7.1.gem ( 95%)
Fetching: nokogiri-1.7.1.gem ( 96%)
Fetching: nokogiri-1.7.1.gem ( 97%)
Fetching: nokogiri-1.7.1.gem ( 98%)
Fetching: nokogiri-1.7.1.gem ( 99%)
Fetching: nokogiri-1.7.1.gem (100%)
Fetching: nokogiri-1.7.1.gem (100%)
ERROR:  Error installing pdd:
	nokogiri requires Ruby version >= 2.1.0.
container 17eba5c1ab11966bf527e865fdf53529ff3f194f5ba22936f5c2a4be0f7e5661 is dead
Tue Apr 25 15:27:31 UTC 2017

yegor256 · 2017-04-25T21:04:54Z

@rultor release, tag is 0.8.1

rultor · 2017-04-25T21:07:53Z

@yegor256 OK, I will release it now. Please check the progress here

rultor · 2017-04-25T21:10:05Z

@smartclash @yegor256 Oops, I failed. You can see the full log here (spent 2min)

++ sed 's/ /\n/g'
++ uptime
++ tail -n 1
+ load=4.50
++ bc
++ echo 4.50 '>' 30
+ '[' 0 -eq 1 ']'
+ echo 'load average is 4.50, low enough to run a new Docker container'
load average is 4.50, low enough to run a new Docker container
+ break
+ cd ..
+ '[' -n '' ']'
+ use_image=yegor256/rultor
+ docker pull yegor256/rultor
Using default tag: latest
Trying to pull repository docker.io/yegor256/rultor ... latest: Pulling from yegor256/rultor
Digest: sha256:3e717a1bd24dd6bc039e59b0e4191ebd3242d3cb83d9b14b8fdbdbd7cb93abf1
Status: Image is up to date for docker.io/yegor256/rultor:latest

+ docker ps --filter=status=exited
+ grep --quiet '\syegor256_tacit_62\s*$'
+ ls -al .
total 36
drwx------   3 rultor rultor   96 Apr 25 21:08 .
drwxrwxrwt. 10 root   root   4096 Apr 25 21:08 ..
-rwxrwxr-x   1 rultor rultor  338 Apr 25 21:08 entry.sh
-rw-rw-r--   1 rultor rultor    6 Apr 25 21:08 pid
drwxrwxr-x   4 rultor rultor 4096 Apr 25 21:08 repo
-rwxrwxr-x   1 rultor rultor 4957 Apr 25 21:08 run.sh
-rw-rw-r--   1 rultor rultor   98 Apr 25 21:08 s3cfg
-rw-rw-r--   1 rultor rultor  887 Apr 25 21:08 script.sh
-rw-rw-r--   1 rultor rultor 3816 Apr 25 21:08 stdout
++ pwd
++ pwd
+ docker run -t --rm -v /tmp/rultor-N07P:/main --env=head=git@github.com:yegor256/tacit.git --env=head_branch=master --env=tag=0.8.1 --hostname=docker --privileged --memory=6g --memory-swap=16g --oom-kill-disable --cidfile=/tmp/rultor-N07P/cid -w=/main --name=yegor256_tacit_62 yegor256/rultor /main/entry.sh
Usage of loopback devices is strongly discouraged for production use. Either use `--storage-opt dm.thinpooldev` or use `--storage-opt dm.no_warn_on_loop_devices=true` to suppress this warning.
+ set -e
+ set -o pipefail
+ shopt -s dotglob
+ useradd -m -G sudo r
+ echo '%sudo ALL=(ALL) NOPASSWD:ALL'
+ cp -R /root/.bashrc /root/.composer /root/.gem /root/.gnupg /root/.m2 /root/.npm /root/.profile /root/texmf /root/tmp /home/r
+ cp -R ./cid ./end.sh ./entry.sh ./pid ./repo ./run.sh ./s3cfg ./script.sh ./stdout /home/r
+ rm -rf repo
+ chown -R r:r /home/r
+ chmod a+x /home/r/script.sh
+ su --login r --command /home/r/script.sh
+ set -e
+ set -o pipefail
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ sudo gem install --no-ri pdd
Fetching: mini_portile2-2.1.0.gem
Fetching: mini_portile2-2.1.0.gem ( 87%)
Fetching: mini_portile2-2.1.0.gem (100%)
Fetching: mini_portile2-2.1.0.gem (100%)
Fetching: nokogiri-1.7.1.gem
Fetching: nokogiri-1.7.1.gem (  1%)
Fetching: nokogiri-1.7.1.gem (  2%)
Fetching: nokogiri-1.7.1.gem (  3%)
Fetching: nokogiri-1.7.1.gem (  4%)
Fetching: nokogiri-1.7.1.gem (  5%)
Fetching: nokogiri-1.7.1.gem (  6%)
Fetching: nokogiri-1.7.1.gem (  7%)
Fetching: nokogiri-1.7.1.gem (  8%)
Fetching: nokogiri-1.7.1.gem (  9%)
Fetching: nokogiri-1.7.1.gem ( 10%)
Fetching: nokogiri-1.7.1.gem ( 11%)
Fetching: nokogiri-1.7.1.gem ( 12%)
Fetching: nokogiri-1.7.1.gem ( 13%)
Fetching: nokogiri-1.7.1.gem ( 14%)
Fetching: nokogiri-1.7.1.gem ( 15%)
Fetching: nokogiri-1.7.1.gem ( 16%)
Fetching: nokogiri-1.7.1.gem ( 17%)
Fetching: nokogiri-1.7.1.gem ( 18%)
Fetching: nokogiri-1.7.1.gem ( 19%)
Fetching: nokogiri-1.7.1.gem ( 20%)
Fetching: nokogiri-1.7.1.gem ( 21%)
Fetching: nokogiri-1.7.1.gem ( 22%)
Fetching: nokogiri-1.7.1.gem ( 23%)
Fetching: nokogiri-1.7.1.gem ( 24%)
Fetching: nokogiri-1.7.1.gem ( 25%)
Fetching: nokogiri-1.7.1.gem ( 26%)
Fetching: nokogiri-1.7.1.gem ( 27%)
Fetching: nokogiri-1.7.1.gem ( 28%)
Fetching: nokogiri-1.7.1.gem ( 29%)
Fetching: nokogiri-1.7.1.gem ( 30%)
Fetching: nokogiri-1.7.1.gem ( 31%)
Fetching: nokogiri-1.7.1.gem ( 32%)
Fetching: nokogiri-1.7.1.gem ( 33%)
Fetching: nokogiri-1.7.1.gem ( 34%)
Fetching: nokogiri-1.7.1.gem ( 35%)
Fetching: nokogiri-1.7.1.gem ( 36%)
Fetching: nokogiri-1.7.1.gem ( 37%)
Fetching: nokogiri-1.7.1.gem ( 38%)
Fetching: nokogiri-1.7.1.gem ( 39%)
Fetching: nokogiri-1.7.1.gem ( 40%)
Fetching: nokogiri-1.7.1.gem ( 41%)
Fetching: nokogiri-1.7.1.gem ( 42%)
Fetching: nokogiri-1.7.1.gem ( 43%)
Fetching: nokogiri-1.7.1.gem ( 44%)
Fetching: nokogiri-1.7.1.gem ( 45%)
Fetching: nokogiri-1.7.1.gem ( 46%)
Fetching: nokogiri-1.7.1.gem ( 47%)
Fetching: nokogiri-1.7.1.gem ( 48%)
Fetching: nokogiri-1.7.1.gem ( 49%)
Fetching: nokogiri-1.7.1.gem ( 50%)
Fetching: nokogiri-1.7.1.gem ( 51%)
Fetching: nokogiri-1.7.1.gem ( 52%)
Fetching: nokogiri-1.7.1.gem ( 53%)
Fetching: nokogiri-1.7.1.gem ( 54%)
Fetching: nokogiri-1.7.1.gem ( 55%)
Fetching: nokogiri-1.7.1.gem ( 56%)
Fetching: nokogiri-1.7.1.gem ( 57%)
Fetching: nokogiri-1.7.1.gem ( 58%)
Fetching: nokogiri-1.7.1.gem ( 59%)
Fetching: nokogiri-1.7.1.gem ( 60%)
Fetching: nokogiri-1.7.1.gem ( 61%)
Fetching: nokogiri-1.7.1.gem ( 62%)
Fetching: nokogiri-1.7.1.gem ( 63%)
Fetching: nokogiri-1.7.1.gem ( 64%)
Fetching: nokogiri-1.7.1.gem ( 65%)
Fetching: nokogiri-1.7.1.gem ( 66%)
Fetching: nokogiri-1.7.1.gem ( 67%)
Fetching: nokogiri-1.7.1.gem ( 68%)
Fetching: nokogiri-1.7.1.gem ( 69%)
Fetching: nokogiri-1.7.1.gem ( 70%)
Fetching: nokogiri-1.7.1.gem ( 71%)
Fetching: nokogiri-1.7.1.gem ( 72%)
Fetching: nokogiri-1.7.1.gem ( 73%)
Fetching: nokogiri-1.7.1.gem ( 74%)
Fetching: nokogiri-1.7.1.gem ( 75%)
Fetching: nokogiri-1.7.1.gem ( 76%)
Fetching: nokogiri-1.7.1.gem ( 77%)
Fetching: nokogiri-1.7.1.gem ( 78%)
Fetching: nokogiri-1.7.1.gem ( 79%)
Fetching: nokogiri-1.7.1.gem ( 80%)
Fetching: nokogiri-1.7.1.gem ( 81%)
Fetching: nokogiri-1.7.1.gem ( 82%)
Fetching: nokogiri-1.7.1.gem ( 83%)
Fetching: nokogiri-1.7.1.gem ( 84%)
Fetching: nokogiri-1.7.1.gem ( 85%)
Fetching: nokogiri-1.7.1.gem ( 86%)
Fetching: nokogiri-1.7.1.gem ( 87%)
Fetching: nokogiri-1.7.1.gem ( 88%)
Fetching: nokogiri-1.7.1.gem ( 89%)
Fetching: nokogiri-1.7.1.gem ( 90%)
Fetching: nokogiri-1.7.1.gem ( 91%)
Fetching: nokogiri-1.7.1.gem ( 92%)
Fetching: nokogiri-1.7.1.gem ( 93%)
Fetching: nokogiri-1.7.1.gem ( 94%)
Fetching: nokogiri-1.7.1.gem ( 95%)
Fetching: nokogiri-1.7.1.gem ( 96%)
Fetching: nokogiri-1.7.1.gem ( 97%)
Fetching: nokogiri-1.7.1.gem ( 98%)
Fetching: nokogiri-1.7.1.gem ( 99%)
Fetching: nokogiri-1.7.1.gem (100%)
Fetching: nokogiri-1.7.1.gem (100%)
ERROR:  Error installing pdd:
	nokogiri requires Ruby version >= 2.1.0.
container 4e78284f1b71a84b035dff14b6bd176c8a0ceb89799122240b42a9e5410f0a69 is dead
Tue Apr 25 21:10:00 UTC 2017

smartclash · 2017-04-26T12:02:11Z

@yegor256 Okay, awesome that you've actually started using RawGit CDN. But still, you are doing some mistakes. Actually, the CDN caches the data for 10years. So, if you make a change, you will not get the changes reflected into the CDN. So, you must include the version tag in the URL so that you get the correct source.

But, while developing you can remove the cdn.rawgit.com to rawgit.com and get the latest build. But should only be used in developing time because extensive pinging in the development URI could make the link dead and your website (or the client) website will not work properly.

For more information on which URL to use in which way, please refer to https://github.com/rgrove/rawgit/blob/master/FAQ.md#whats-the-difference-between-development-and-cdn-urls

yegor256 · 2017-04-26T14:16:39Z

@smartclash please, check my changes in d53a8c2 What do you think now?

yegor256 · 2017-04-26T14:35:44Z

@rultor release, tag is 0.8.1

rultor · 2017-04-26T14:37:20Z

@yegor256 OK, I will release it now. Please check the progress here

rultor · 2017-04-26T14:39:19Z

@smartclash @yegor256 Oops, I failed. You can see the full log here (spent 2min)

    Compass is charityware. If you love it, please donate on our behalf at http://umdf.org/compass Thanks!
Successfully installed compass-1.0.3
5 gems installed
+ sudo -i gem install --no-ri scss-lint
Fetching: rainbow-2.2.2.gem
Fetching: rainbow-2.2.2.gem ( 11%)
Fetching: rainbow-2.2.2.gem ( 26%)
Fetching: rainbow-2.2.2.gem ( 41%)
Fetching: rainbow-2.2.2.gem ( 55%)
Fetching: rainbow-2.2.2.gem ( 70%)
Fetching: rainbow-2.2.2.gem ( 84%)
Fetching: rainbow-2.2.2.gem ( 99%)
Fetching: rainbow-2.2.2.gem (100%)
Fetching: rainbow-2.2.2.gem (100%)
Building native extensions.  This could take a while...
Successfully installed rainbow-2.2.2
Fetching: scss-lint-0.38.0.gem
Fetching: scss-lint-0.38.0.gem (  3%)
Fetching: scss-lint-0.38.0.gem (  6%)
Fetching: scss-lint-0.38.0.gem ( 10%)
Fetching: scss-lint-0.38.0.gem ( 13%)
Fetching: scss-lint-0.38.0.gem ( 17%)
Fetching: scss-lint-0.38.0.gem ( 20%)
Fetching: scss-lint-0.38.0.gem ( 24%)
Fetching: scss-lint-0.38.0.gem ( 27%)
Fetching: scss-lint-0.38.0.gem ( 30%)
Fetching: scss-lint-0.38.0.gem ( 34%)
Fetching: scss-lint-0.38.0.gem ( 37%)
Fetching: scss-lint-0.38.0.gem ( 41%)
Fetching: scss-lint-0.38.0.gem ( 61%)
Fetching: scss-lint-0.38.0.gem ( 82%)
Fetching: scss-lint-0.38.0.gem (100%)
Fetching: scss-lint-0.38.0.gem (100%)
WARNING: `scss-lint` has been renamed to `scss_lint` to follow proper RubyGems naming conventions. Update your Gemfile or relevant install scripts to install `scss_lint`.
Successfully installed scss-lint-0.38.0
2 gems installed
+ sudo -i npm install
\u001b[37;40mnpm\u001b[0m \u001b[0m\u001b[30;43mWARN\u001b[0m \u001b[0m\u001b[35mnpm\u001b[0m npm does not support Node.js v0.10.25
\u001b[0m\u001b[37;40mnpm\u001b[0m \u001b[0m\u001b[30;43mWARN\u001b[0m \u001b[0m\u001b[35mnpm\u001b[0m You should probably upgrade to a newer version of node as we
\u001b[0m\u001b[37;40mnpm\u001b[0m \u001b[0m\u001b[30;43mWARN\u001b[0m \u001b[0m\u001b[35mnpm\u001b[0m can't make any promises that npm will work with this version.
\u001b[0m\u001b[37;40mnpm\u001b[0m \u001b[0m\u001b[30;43mWARN\u001b[0m \u001b[0m\u001b[35mnpm\u001b[0m You can find the latest version at https://nodejs.org/
\u001b[0m\u001b[?25l[\u001b[90m..................\u001b[0m] \ normalizeTree: \u001b[7msill\u001b[0m \u001b[35minstall\u001b[0m loadCurrentTree\u001b[K

\u001b[K\u001b[?25h\u001b[37;40mnpm\u001b[0m \u001b[0m\u001b[30;43mWARN\u001b[0m \u001b[0m\u001b[35menoent\u001b[0m ENOENT, open '/root/package.json'
\u001b[0m\u001b[37;40mnpm\u001b[0m \u001b[0m\u001b[30;43mWARN\u001b[0m\u001b[35m\u001b[0m root No description
\u001b[0m\u001b[37;40mnpm\u001b[0m \u001b[0m\u001b[30;43mWARN\u001b[0m\u001b[35m\u001b[0m root No repository field.
\u001b[0m\u001b[37;40mnpm\u001b[0m \u001b[0m\u001b[30;43mWARN\u001b[0m\u001b[35m\u001b[0m root No README data
\u001b[0m\u001b[37;40mnpm\u001b[0m \u001b[0m\u001b[30;43mWARN\u001b[0m\u001b[35m\u001b[0m root No license field.
\u001b[0m+ sed -i 's/1\.0\.0//g' package.json
+ sed -i 's/1\.0\.0//g' bower.json
+ sed -i s/VERSION//g index.html
+ git rm -rf dist/ --ignore-unmatch
+ npm run rultor --no-color
npm WARN npm npm does not support Node.js v0.10.25
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm You can find the latest version at https://nodejs.org/

> tacit@ rultor /home/r/repo
> grunt rultor --no-color

sh: 1: grunt: not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! tacit@ rultor: `grunt rultor --no-color`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the tacit@ rultor script 'grunt rultor --no-color'.
npm ERR! Make sure you have the latest version of node.js and npm installed.
npm ERR! If you do, this is most likely a problem with the tacit package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     grunt rultor --no-color
npm ERR! You can get information on how to open an issue for this project with:
npm ERR!     npm bugs tacit
npm ERR! Or if that isn't available, you can get their info via:
npm ERR!     npm owner ls tacit
npm ERR! There is likely additional logging output above.
npm WARN Local package.json exists, but node_modules missing, did you mean to install?

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/r/.npm/_logs/2017-04-26T14_37_44_672Z-debug.log
container 31b43f6b14c0d03b9bb6ab540342e71a7908d4858f764d0ebf6a14bbf5090448 is dead
Wed Apr 26 14:39:14 UTC 2017

yegor256 · 2017-04-26T14:43:25Z

@kt3k can you please help me here? I don't understand why it can't find grunt. I don't think I changed anything, except for the -i flag for sudo

smartclash · 2017-04-26T15:11:58Z

@yegor256 Don't let the person downloading your project find the version. You do the hardwork. Replace the URL to https://cdn.rawgit.com/yegor256/tacit/0.8.0/dist/tacit-0.8.0.min.css. There are many other plug-and-play frameworks. So, people might not be intrested in finding the version and linking it.

Better provide this link (latest CSS) : https://cdn.rawgit.com/yegor256/tacit/0.8.0/dist/tacit-0.8.0.min.css

kt3k · 2017-04-27T02:54:38Z

@yegor256
sudo -i seems to change the working directory to root's home directory and that caused the problem. npm install installs the dependencies in local directory, so maybe dependencies were installed in root's home.

npm install should work without root privilege, so I guess dropping sudo before npm install would solve the problem.

yegor256 · 2017-04-27T14:21:21Z

@rultor release tag is 0.8.1

rultor · 2017-04-27T14:23:25Z

@yegor256 OK, I will release it now. Please check the progress here

rultor · 2017-04-27T14:25:19Z

@smartclash @yegor256 Oops, I failed. You can see the full log here (spent 2min)

  | +-- \u001b[40m\u001b[33marray-differ@1.0.0\u001b[39m\u001b[49m 
  | +-- \u001b[40m\u001b[33marray-union@1.0.2\u001b[39m\u001b[49m 
  | | `-- \u001b[40m\u001b[33marray-uniq@1.0.3\u001b[39m\u001b[49m 
  | +-- \u001b[40m\u001b[33marrify@1.0.1\u001b[39m\u001b[49m  \u001b[90mdeduped\u001b[39m
  | `-- \u001b[40m\u001b[33mminimatch@3.0.3\u001b[39m\u001b[49m  \u001b[90mdeduped\u001b[39m
  +-- \u001b[40m\u001b[33mpkg-up@1.0.0\u001b[39m\u001b[49m 
  | `-- \u001b[40m\u001b[33mfind-up@1.1.2\u001b[39m\u001b[49m 
  |   +-- \u001b[40m\u001b[33mpath-exists@2.1.0\u001b[39m\u001b[49m 
  |   | `-- \u001b[40m\u001b[33mpinkie-promise@2.0.1\u001b[39m\u001b[49m  \u001b[90mdeduped\u001b[39m
  |   `-- \u001b[40m\u001b[33mpinkie-promise@2.0.1\u001b[39m\u001b[49m 
  |     `-- \u001b[40m\u001b[33mpinkie@2.0.4\u001b[39m\u001b[49m 
  `-- \u001b[40m\u001b[33mresolve-pkg@0.1.0\u001b[39m\u001b[49m 
    `-- \u001b[40m\u001b[33mresolve-from@2.0.0\u001b[39m\u001b[49m 

\u001b[37;40mnpm\u001b[0m \u001b[0m\u001b[30;43mWARN\u001b[0m\u001b[35m\u001b[0m tacit@1.0.0 license should be a valid SPDX license expression
\u001b[0m+ sed -i 's/1\.0\.0/0.8.1/g' package.json
+ sed -i 's/1\.0\.0/0.8.1/g' bower.json
+ sed -i s/VERSION/0.8.1/g index.html
+ git rm -rf dist/ --ignore-unmatch
+ npm run rultor --no-color
npm WARN npm npm does not support Node.js v0.10.25
npm WARN npm You should probably upgrade to a newer version of node as we
npm WARN npm can't make any promises that npm will work with this version.
npm WARN npm You can find the latest version at https://nodejs.org/
\u001b[?25l[..................] - : verb node symlink /usr/bin/node\u001b[K

\u001b[K\u001b[?25h
> tacit@0.8.1 rultor /home/r/repo
> grunt rultor --no-color

Running "scsslint:allFiles" (scsslint) task
Running scss-lint on allFiles
>> 9 files are lint free

Running "sass:dist" (sass) task

Running "sass:uncompressed" (sass) task

Running "shell:target" (shell) task

Done.
+ git add -f dist/tacit-0.8.1.min.css
+ git add -f dist/tacit-0.8.1.min.css.map
+ git add -f dist/tacit-0.8.1.css
+ git commit -am 0.8.1
[__rultor de4ae68] 0.8.1
 6 files changed, 529 insertions(+), 7 deletions(-)
 create mode 100644 dist/tacit-0.8.1.css
 create mode 100644 dist/tacit-0.8.1.min.css
 create mode 100644 dist/tacit-0.8.1.min.css.map
+ mv dist/tacit-0.8.1.min.css /tmp
+ mv index.html /tmp
+ git checkout gh-pages
Branch gh-pages set up to track remote branch gh-pages from origin.
Switched to a new branch 'gh-pages'
+ git reset --hard
HEAD is now at f4e3580 0.8.0
+ sudo -i git clean -fd
fatal: Not a git repository (or any of the parent directories): .git
container 489899e32bb3d5303cc1e75283242130b3822b557031b44af1e00c37a5fb1366 is dead
Thu Apr 27 14:25:13 UTC 2017

yegor256 · 2017-04-28T05:25:29Z

@rultor release tag is 0.8.1

rultor · 2017-04-28T05:26:10Z

@yegor256 OK, I will release it now. Please check the progress here

rultor · 2017-04-28T05:30:09Z

@yegor256 Done! FYI, the full log is here (took me 4min)

yegor256 · 2017-04-28T05:33:22Z

@kt3k thanks, it worked!

yegor256 · 2017-04-28T05:33:59Z

@smartclash I didn't understand your comment. Both links you provided are exactly the same :( Can you please explain again?

smartclash · 2017-04-28T11:27:33Z

@yegor256 Well, no prob. I will make a PR soon for it :)

smartclash · 2017-04-28T12:02:09Z

@yegor256 Okay, made some PR. check out #64 and #65

yegor256 · 2017-04-29T05:52:03Z

@smartclash thanks! #64 is not technically correct, since it goes to gh-pages #65 has some issues, please see my comments there

filfreire · 2018-03-17T18:44:26Z

@yegor256 I think the main purpose of this issue and usage of a CDN is done. I suggest we close this issue in particular and if @smartclash wishes, @smartclash can open an issue following-up comment #62 (comment) with more detail and even open PRs.

smartclash · 2018-03-18T08:13:35Z

Hey there @yegor256 and @filfreire,

Sorry I was off from this PR and failed to contribute. Well, idea of @filfreire is good. We can make up a issue in that comment and close this issue. Okay?

filfreire · 2018-04-17T07:22:01Z

@smartclash as discussed above, I'm closing this issue. Feel free to open an issue following-up comment #62 (comment) with more detail and even open PRs.

0crat · 2018-04-17T07:37:15Z

The job is not in WBS, won't close the order

yegor256 added a commit that referenced this issue Apr 25, 2017

#62 rawgit CDN

637b357

yegor256 added a commit that referenced this issue Apr 26, 2017

#62 version

d53a8c2

yegor256 added a commit that referenced this issue Apr 27, 2017

#62 sudo removed

7522e4f

yegor256 added a commit that referenced this issue Apr 28, 2017

#62 sudo fixed

497efb2

filfreire closed this as completed Apr 17, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improper CSS file inclusion technique #62

Improper CSS file inclusion technique #62

smartclash commented Apr 12, 2017

0crat commented Apr 12, 2017

yegor256 commented Apr 25, 2017

rultor commented Apr 25, 2017

rultor commented Apr 25, 2017

yegor256 commented Apr 25, 2017

rultor commented Apr 25, 2017

rultor commented Apr 25, 2017

smartclash commented Apr 26, 2017

yegor256 commented Apr 26, 2017

yegor256 commented Apr 26, 2017

rultor commented Apr 26, 2017

rultor commented Apr 26, 2017

yegor256 commented Apr 26, 2017

smartclash commented Apr 26, 2017 •

edited

kt3k commented Apr 27, 2017

yegor256 commented Apr 27, 2017

rultor commented Apr 27, 2017

rultor commented Apr 27, 2017

yegor256 commented Apr 28, 2017

rultor commented Apr 28, 2017

rultor commented Apr 28, 2017

yegor256 commented Apr 28, 2017

yegor256 commented Apr 28, 2017

smartclash commented Apr 28, 2017

smartclash commented Apr 28, 2017

yegor256 commented Apr 29, 2017

filfreire commented Mar 17, 2018

smartclash commented Mar 18, 2018

filfreire commented Apr 17, 2018

0crat commented Apr 17, 2018

Improper CSS file inclusion technique #62

Improper CSS file inclusion technique #62

Comments

smartclash commented Apr 12, 2017

0crat commented Apr 12, 2017

yegor256 commented Apr 25, 2017

rultor commented Apr 25, 2017

rultor commented Apr 25, 2017

yegor256 commented Apr 25, 2017

rultor commented Apr 25, 2017

rultor commented Apr 25, 2017

smartclash commented Apr 26, 2017

yegor256 commented Apr 26, 2017

yegor256 commented Apr 26, 2017

rultor commented Apr 26, 2017

rultor commented Apr 26, 2017

yegor256 commented Apr 26, 2017

smartclash commented Apr 26, 2017 • edited

kt3k commented Apr 27, 2017

yegor256 commented Apr 27, 2017

rultor commented Apr 27, 2017

rultor commented Apr 27, 2017

yegor256 commented Apr 28, 2017

rultor commented Apr 28, 2017

rultor commented Apr 28, 2017

yegor256 commented Apr 28, 2017

yegor256 commented Apr 28, 2017

smartclash commented Apr 28, 2017

smartclash commented Apr 28, 2017

yegor256 commented Apr 29, 2017

filfreire commented Mar 17, 2018

smartclash commented Mar 18, 2018

filfreire commented Apr 17, 2018

0crat commented Apr 17, 2018

smartclash commented Apr 26, 2017 •

edited