Make HTML5 compatible and some little changes #65
Conversation
README.md
Outdated
| <head> | ||
| <link rel="stylesheet" href="https://cdn.rawgit.com/yegor256/tacit/gh-pages/tacit-VERSION.min.css"/> | ||
| <meta charset="UTF-8"> | ||
| <link rel="stylesheet" href="https://cdn.rawgit.com/yegor256/tacit/gh-pages/tacit-0.8.1.min.css"/> |
There was a problem hiding this comment.
This 0.8.1 will stay here even after we release, say, 0.9.0. We will have to remember that these numbers have to be modified manually every time we release a new version? :) Not really what continuous delivery is about.
| </html> | ||
| ``` | ||
|
|
||
| Or simply download [`tacit.min.css`](https://raw.githubusercontent.com/yegor256/tacit/gh-pages/tacit.min.css) | ||
| Or simply download [`tacit.min.css`](https://cdn.rawgit.com/yegor256/tacit/gh-pages/tacit-0.8.1.min.css) |
There was a problem hiding this comment.
@smartclash the same problem here. We should not use explicit numbers in README.md
There was a problem hiding this comment.
@smartclash please, remove this change. We should point to the latest version always, in the README.
|
@smartclash see some comments above |
|
@yegor256 Sure, you are right. But the problem is, you are making this CSS file just for people who are complete noobs about web technologies and other things. And making them to go to the release section and fetch the version manually and including it is like a nightmare for them (provided they are complete noob). So, that's why I am saying this. I hope you can understand. And hey, your rultor is awesome. I am using it for my project too. |
|
@smartclash hey, it's just a single click to check the latest version in the "releases" section. Even a monkey can figure it out :) Let's remove that change from the PR and I'll merge it. |
|
@yegor256 Okay, awesome. Let's make it up :) |
|
DONE!! |
|
@smartclash thanks! One more comment you seemed to forget. |
|
@smartclash can you solve the conflicts in |
|
@yegor256 the user @smartclash hasn't solved the conflicts since May and after I mentioned him 17 days ago. I believe we can close this PR. @smartclash if you wish to re-open the PR I suggest fixing the conflicts and opening a new one, or doing the changes from a fresh start. Thank your for all your contributions 👍 |
|
@filfreire closed |
Okay, let's make it production ready. Can't we?