Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TkMethods returns 404 on unsupported method #861

Closed
g4s8 opened this issue Oct 16, 2018 · 18 comments
Closed

TkMethods returns 404 on unsupported method #861

g4s8 opened this issue Oct 16, 2018 · 18 comments

Comments

@g4s8
Copy link
Contributor

g4s8 commented Oct 16, 2018

TkMethods take returns 404 error if method is not supported.
It would be more logical to return 405: Method Not Allowed here.

new FtRemote(new TkMethods(new TkEmpty(), "PUT")).exec(
    url -> new JdkRequest(url)
        .method("POST")
        .fetch().as(RestResponse.class)
        // expecting 405: Method Not Allowed.
        .assertStatus(HttpURLConnection.HTTP_BAD_METHOD)
);
// java.lang.AssertionError: HTTP response status is not equal to 405: 404 Not Found
@0crat
Copy link
Collaborator

0crat commented Oct 16, 2018

@paulodamaso/z please, pay attention to this issue

@paulodamaso
Copy link
Contributor

@0crat in

@0crat 0crat added the scope label Oct 17, 2018
@0crat
Copy link
Collaborator

0crat commented Oct 17, 2018

@0crat in (here)

@paulodamaso Job #861 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented Oct 17, 2018

Bug was reported, see §29: +15 point(s) just awarded to @g4s8/z

@0crat
Copy link
Collaborator

0crat commented Nov 12, 2018

The job #861 assigned to @ypshenychka/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@ypshenychka
Copy link

@0crat refuse

@0crat
Copy link
Collaborator

0crat commented Nov 12, 2018

@0crat refuse (here)

@ypshenychka The user @ypshenychka/z resigned from #861, please stop working. Reason for job resignation: Order was cancelled

@0crat
Copy link
Collaborator

0crat commented Nov 12, 2018

Tasks refusal is discouraged, see §6: -15 point(s) just awarded to @ypshenychka/z

@0crat
Copy link
Collaborator

0crat commented Nov 24, 2018

The job #861 assigned to @victornoel/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@victornoel
Copy link
Contributor

@0crat wait for review/merge of #875

@0crat
Copy link
Collaborator

0crat commented Nov 28, 2018

@0crat wait for review/merge of #875 (here)

@victornoel The impediment for #861 was registered successfully by @victornoel/z

victornoel added a commit to victornoel/takes that referenced this issue Dec 1, 2018
@victornoel
Copy link
Contributor

@g4s8 the PR was merged, can you close the issue? Thanks

@g4s8
Copy link
Contributor Author

g4s8 commented Dec 4, 2018

@victornoel thanks

@g4s8 g4s8 closed this as completed Dec 4, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 4, 2018

@ypshenychka/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@0crat 0crat removed the scope label Dec 4, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 4, 2018

The job #861 is now out of scope

@ypshenychka
Copy link

@0crat quality good

@0crat
Copy link
Collaborator

0crat commented Dec 4, 2018

Order was finished, quality is "good": +35 point(s) just awarded to @victornoel/z

@0crat
Copy link
Collaborator

0crat commented Dec 4, 2018

Quality review completed: +8 point(s) just awarded to @ypshenychka/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants