Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DyRepos.add() does not include a message when throwing IllegalArgumentException #529

Closed
carlosmiranda opened this issue Mar 19, 2015 · 5 comments

Comments

@carlosmiranda
Copy link
Contributor

At the moment, DyRepos.add() will throw an IllegalArgumentException when it finds that the supplied repo already exists. However, it does not include any message in the exception that it throws, which does not help in finding out what went wrong.

We should add an exception message that specifically states what happened, something similar to:

Repo [repo name] already exists

@carlosmiranda
Copy link
Contributor Author

@davvd This is a valid bug.

@davvd
Copy link
Collaborator

davvd commented Mar 19, 2015

@davvd This is a valid bug.

@carlosmiranda OK, I labeled it as bug

@davvd davvd added the bug label Mar 19, 2015
@davvd
Copy link
Collaborator

davvd commented Mar 19, 2015

@carlosmiranda thanks for reporting! I topped your account for 15 mins, transaction 53764880

yegor256 pushed a commit that referenced this issue Jul 29, 2015
@yegor256
Copy link
Owner

@carlosmiranda fixed in acfa045

@carlosmiranda
Copy link
Contributor Author

@yegor256 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants