Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#421 Implemented DyTasks.open() method #531

Merged
merged 3 commits into from Mar 24, 2015
Merged

#421 Implemented DyTasks.open() method #531

merged 3 commits into from Mar 24, 2015

Conversation

carlosmiranda
Copy link
Contributor

No description provided.

@carlosmiranda carlosmiranda mentioned this pull request Mar 23, 2015
Closed
@davvd
Copy link
Collaborator

davvd commented Mar 23, 2015

Thanks, let me find someone who can review this pull request

@davvd
Copy link
Collaborator

davvd commented Mar 23, 2015

@longtimeago review this one, please

longtimeago
longtimeago reviewed Mar 24, 2015
View reviewed changes
src/test/java/com/thindeck/dynamo/DyTasksTest.java
@Test
public void fetchesOpenTasks() throws Exception {
final Repo repo = new MkRepo();
final long[] closed = new long[]{0L, 1L, 2L};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be inlined

@longtimeago
Copy link
Contributor

@carlosmiranda very good! jus one minor remark. Thanks!

@carlosmiranda
Copy link
Contributor Author

@longtimeago Fixed, please check again (Travis build failed because of network failure)

@longtimeago
Copy link
Contributor

@carlosmiranda thanks!

@longtimeago
Copy link
Contributor

@rultor merge please

@rultor
Copy link
Collaborator

rultor commented Mar 24, 2015

@rultor merge please

@longtimeago Thanks for your request. @carlosmiranda Please confirm this.

@carlosmiranda
Copy link
Contributor Author

@yegor256 can you take a look and confirm this merge?

@yegor256
Copy link
Owner

@rultor merge pls

@rultor
Copy link
Collaborator

rultor commented Mar 24, 2015

@rultor merge pls

@yegor256 Thanks for your request. @carlosmiranda Please confirm this.

@carlosmiranda
Copy link
Contributor Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Mar 24, 2015

@rultor merge

@carlosmiranda OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 5fd20d5 into yegor256:master Mar 24, 2015
@rultor
Copy link
Collaborator

rultor commented Mar 24, 2015

@rultor merge

@carlosmiranda Done! FYI, the full log is here (took me 17min)

@davvd
Copy link
Collaborator

davvd commented Mar 26, 2015

@longtimeago Many thanks! 18 mins were added to your account in Transaction ID 54222788 (task took 47 hours and 54 mins). you're getting extra minutes here (c=3). +18 added to your rating, at the moment it is: +3675

@davvd
Copy link
Collaborator

davvd commented Mar 26, 2015

@rultor deploy

@rultor
Copy link
Collaborator

rultor commented Mar 26, 2015

@rultor deploy

@davvd OK, I'll try to deploy now. You can check the progress here

@rultor
Copy link
Collaborator

rultor commented Mar 26, 2015

@rultor deploy

@davvd Done! FYI, the full log is here (took me 17min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@longtimeago
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carlosmiranda @davvd @longtimeago @rultor @yegor256