Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All RUN commands were joined in order to minimize the layers size. #14

Closed
wants to merge 5 commits into from

Conversation

dgroup
Copy link

@dgroup dgroup commented Sep 29, 2017

During docker image building procedure you may observe warning
[WARNING]: Empty continuation line found.

It happens due to comments between multiple commands in the RUN statement.
The fix is quite simple - remove the comments.
From my points of view these comments are useful, thus I kept them as is.

That's a docker bug, nothing critical just a warning, see more details here - moby/moby#35004.

Could you, please, add me as a contributor?
Email: dgroup@ex.ua

During docker image building procedure you may observe warning `[WARNING]: Empty continuation line found`.
This is docker bug, see more details here:
 - moby/moby#35004
 - appropriate/docker-jetty#79
@0crat
Copy link
Collaborator

0crat commented Sep 29, 2017

@yegor256 please, pay attention to this pull request

@0crat
Copy link
Collaborator

0crat commented Sep 29, 2017

Job gh:yegor256/threecopies#14 is in scope.

dubinka added 2 commits September 29, 2017 19:08
Allows to disable warning `[WARNING]: Empty continuation line found`
@yegor256
Copy link
Owner

@dgroup feel free to create "Contributors" section in README, if you want to be there, just like it's done here, for example: https://github.com/yegor256/cactoos#contributors

@yegor256
Copy link
Owner

@dgroup on a second thought it looks like an abuse of Docker file structure. We definitely should group commands, but not all commands in one RUN. Let's have groups.

@0crat
Copy link
Collaborator

0crat commented Apr 12, 2018

@yegor256/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually or invite more people to the project, as explained in §51

@0crat
Copy link
Collaborator

0crat commented Apr 17, 2018

@yegor256/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually or invite more people to the project, as explained in §51

@yegor256
Copy link
Owner

@dgroup are you planning to finish this?

@0crat
Copy link
Collaborator

0crat commented Apr 22, 2018

@yegor256/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually or invite more people to the project, as explained in §51

@0crat
Copy link
Collaborator

0crat commented Apr 27, 2018

@yegor256/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@0crat
Copy link
Collaborator

0crat commented May 2, 2018

@yegor256/z everybody who has role DEV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@yegor256
Copy link
Owner

yegor256 commented May 6, 2018

@rultor out

@yegor256
Copy link
Owner

yegor256 commented May 6, 2018

@0crat out

@0crat
Copy link
Collaborator

0crat commented May 6, 2018

@0crat out (here)

@yegor256 The job #14 is now out of scope

@rultor
Copy link
Collaborator

rultor commented May 6, 2018

@rultor out

@yegor256 I'm sorry, I don't understand you :( Check this page and try again please

@yegor256
Copy link
Owner

yegor256 commented May 6, 2018

@0crat out

@0crat
Copy link
Collaborator

0crat commented May 6, 2018

@0crat out (here)

@yegor256 The job is not in WBS, won't close the order

@dgroup
Copy link
Author

dgroup commented May 20, 2018

Hi @yegor256
The changes were done within this pull request.

@dgroup
Copy link
Author

dgroup commented Dec 11, 2018

@yegor256 reminder.

@dgroup dgroup closed this Dec 19, 2018
@0crat
Copy link
Collaborator

0crat commented Dec 19, 2018

Job gh:yegor256/threecopies#14 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Dec 19, 2018

This job is not in scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants