Skip to content

Commit

Permalink
librados: remove new setxattr overload to avoid breaking the C++ ABI
Browse files Browse the repository at this point in the history
Fixes: http://tracker.ceph.com/issues/18058
Signed-off-by: Josh Durgin <jdurgin@redhat.com>
  • Loading branch information
jdurgin committed Nov 29, 2016
1 parent 0e60bf8 commit b8ff781
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
1 change: 0 additions & 1 deletion src/include/rados/librados.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,6 @@ namespace librados
void zero(uint64_t off, uint64_t len);
void rmxattr(const char *name);
void setxattr(const char *name, const bufferlist& bl);
void setxattr(const char *name, const bufferlist&& bl);
void tmap_update(const bufferlist& cmdbl);
void tmap_put(const bufferlist& bl);
void clone_range(uint64_t dst_off,
Expand Down
8 changes: 0 additions & 8 deletions src/librados/librados.cc
Original file line number Diff line number Diff line change
Expand Up @@ -445,14 +445,6 @@ void librados::ObjectWriteOperation::setxattr(const char *name, const bufferlist
o->setxattr(name, v);
}

void librados::ObjectWriteOperation::setxattr(const char *name,
const buffer::list&& v)
{
::ObjectOperation *o = &impl->o;
o->setxattr(name, std::move(v));
}


void librados::ObjectWriteOperation::omap_set(
const map<string, bufferlist> &map)
{
Expand Down

0 comments on commit b8ff781

Please sign in to comment.