Skip to content

Commit

Permalink
Revert "enhance: expect replicas as nil and when hpa is enabled (zill…
Browse files Browse the repository at this point in the history
…iztech#95)"

This reverts commit 5340ed9.
Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
  • Loading branch information
yellow-shine committed Mar 22, 2024
1 parent 14d4f8d commit ca02bff
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions pkg/controllers/components_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -273,16 +273,6 @@ func TestMilvusComponent_GetReplicas(t *testing.T) {
assert.Equal(t, &replica, com.GetReplicas(spec))
}

func TestMilvusComponent_Expect_Replicas_as_Nil_When_HPA(t *testing.T) {
milvus := v1beta1.Milvus{}
spec := milvus.Spec
spec.Com.Proxy = &v1beta1.MilvusProxy{}
com := Proxy
replica := int32(-1)
spec.Com.Proxy.Component.Replicas = &replica
assert.Nil(t, com.GetReplicas(spec))
}

func TestMilvusComponent_GetRunCommands(t *testing.T) {
com := QueryNode
assert.Equal(t, []string{com.Name}, com.GetRunCommands())
Expand Down

0 comments on commit ca02bff

Please sign in to comment.