enhance: expect replicas as nil and when hpa is enabled #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 81.02% 81.07% +0.05%
==========================================
Files 54 54
Lines 5907 5907
==========================================
+ Hits 4786 4789 +3
+ Misses 938 936 -2
+ Partials 183 182 -1 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haorenfsa, samhuang-z The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
yellow-shine
added a commit
that referenced
this pull request
Mar 21, 2024
Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
yellow-shine
added a commit
to yellow-shine/milvus-operator
that referenced
this pull request
Mar 21, 2024
…iztech#95)" This reverts commit 5340ed9.
yellow-shine
added a commit
to yellow-shine/milvus-operator
that referenced
this pull request
Mar 22, 2024
…iztech#95)" This reverts commit 5340ed9. Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
yellow-shine
added a commit
to yellow-shine/milvus-operator
that referenced
this pull request
Mar 22, 2024
…iztech#95)" This reverts commit 5340ed9. Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
yellow-shine
added a commit
to yellow-shine/milvus-operator
that referenced
this pull request
Mar 22, 2024
…iztech#95)" This reverts commit 5340ed9. Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
Mar 22, 2024
* chore: replicas could be -1 Signed-off-by: Liang Huang <sammy.huang@zilliz.com> * feat: no need to update replicas when hpa is enabled Signed-off-by: Liang Huang <sammy.huang@zilliz.com> . Signed-off-by: Liang Huang <sammy.huang@zilliz.com> . Signed-off-by: Liang Huang <sammy.huang@zilliz.com> . Signed-off-by: Liang Huang <sammy.huang@zilliz.com> * Revert "feat: allow replicas as nil and leave it to hpa (#94)" This reverts commit a7a7507. Signed-off-by: Liang Huang <sammy.huang@zilliz.com> * Revert "enhance: expect replicas as nil and when hpa is enabled (#95)" This reverts commit 5340ed9. Signed-off-by: Liang Huang <sammy.huang@zilliz.com> --------- Signed-off-by: Liang Huang <sammy.huang@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.