Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix Private key derivation bug #220

Merged
merged 1 commit into from
Sep 12, 2019
Merged

🐛 Fix Private key derivation bug #220

merged 1 commit into from
Sep 12, 2019

Conversation

usatie
Copy link
Member

@usatie usatie commented Sep 12, 2019

Description of the Change

Fix _HDKey implementation on Linux.

  • Pads with 0 if the length is less than 32 bytes

Benefits

Fix #73

Possible Drawbacks

None.

Applicable Issues

#73

@usatie
🐛 Fix Private key derivation bug
fea199d 
- Pads with 0 if length is less than 32 bytes
@usatie usatie added the bug Something isn't working label Sep 12, 2019
usatie
usatie commented Sep 12, 2019
View reviewed changes
Copy link
Member Author

@usatie usatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usatie usatie merged commit 769363b into master Sep 12, 2019
@usatie usatie deleted the fix-privkey-derivation-bytes branch September 12, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HDPrivateKey derived bug, privateKey mast be 32 bytes
1 participant
@usatie