This repository has been archived by the owner on Mar 26, 2018. It is now read-only.
fix(htmlmin): disable the removeOptionalTags option. #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah. It doesn't save us sooo much bytes so I'd rather save people this pain. 👍 |
kevva
added a commit
that referenced
this pull request
Jun 17, 2015
fix(htmlmin): disable the removeOptionalTags option.
|
👍, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling HTML minifier's
removeOptionalTagsoption alongside libraries like the AngularUI Router causes iOS 8 devices to throw anTypeError: Attempted to assign to readonly propertyerror. See screenshot here.This obscure iOS8 ```TypeError
is a [known issue](https://github.com/angular/angular.js/issues/9128) in AngularJS, but on some cases, the fix is just to [disable removeOptionalTags](https://github.com/angular/angular.js/issues/9128#issuecomment-111648953) fromhtmlmin`. As such, it shouldn't be enabled by default here.