resolve inconsistent usage of options and answers #152
Conversation
| constructor: function () { | ||
| yeoman.Base.apply(this, arguments); | ||
|
|
||
| // This makes 'arg' an optional argument. |
There was a problem hiding this comment.
Let's keep the code boilerplate minimal.
There was a problem hiding this comment.
@SBoudrias can you be more specific?
There was a problem hiding this comment.
We should remove a lot of comments and unnecessary lines of code.
There was a problem hiding this comment.
I can easily remove the comments. Which lines are unnecessary? The examples of reading arguments and options? Other stuff too? Technically we don't need to have an option or argument registered at all, could completely remove the constructor... Give me some more direction and I'll make it happen.
|
@SBoudrias I'm leaving for vacation tomorrow, so I just backed this back to the most simple thing I could imagine based on your comments. Feel free to adjust however you see fit. |
|
Oh thanks, sorry I was too busy to come back to this earlier. That minimal fix seems good to me. |
|
Oh by the way, your commits are not linking back to your github account. Chances are the git email set on the computer from which you sent the PR is not linked to your account. |
|
Interesting, thanks for the heads up. |
added example argument and option registration and updated test to reference these consistently
resolves #151