Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces replace the hyphen on package names #25

Closed
heavysixer opened this issue Feb 27, 2015 · 4 comments
Closed

Spaces replace the hyphen on package names #25

heavysixer opened this issue Feb 27, 2015 · 4 comments

Comments

@heavysixer
Copy link
Contributor

Hi @addyosmani
I noticed that when you have a project with hyphens the generated gruntfile replaces them with spaces. Consider the following:

{
  "name": "appify-components",
  "version": "0.0.0",
  "dependencies": {},
  "devDependencies": {
    "grunt": "~0.4.2",
    "grunt-contrib-watch": "~0.5.3",
    "grunt-contrib-concat": "~0.3.0",
    "grunt-contrib-uglify": "~0.2.7",
    "grunt-contrib-jshint": "~0.7.2",
    "grunt-contrib-qunit": "*"
  }
}
dist: {
                src: ['lib/appify components.js'],
                dest: 'dist/appify components.js'
            }

I am happy to work on a PR for this issue but wanted to make sure this was not done by design first.

@SBoudrias
Copy link
Member

This is not by design, fix welcome!

@heavysixer
Copy link
Contributor Author

@SBoudrias i know we went round and round on this on Friday, but am curious if everything is looking good now? Thanks again for all the help getting this PR in great shape.

@arthurvr
Copy link
Member

arthurvr commented Apr 8, 2015

The PR was merged so this issue can be closed I guess?

@SBoudrias
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants