Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Git hooks #259

Closed
SBoudrias opened this issue Mar 25, 2017 · 1 comment
Closed

[FEAT] Git hooks #259

SBoudrias opened this issue Mar 25, 2017 · 1 comment

Comments

@SBoudrias
Copy link
Member

I think it'd be great to setup pre-commit/pre-push hooks automatically.

I think Husky is a great option. What I have in mind is:

  • pre-commit: run eslint --fix
  • pre-push: run full npm test

My only concern is husky (and other node based pre-commit hooks) will run on all files and not only modified files. This might not be an issue with new projects, but it's a required feature for legacy projects. We don't need to address this right away, but it'd be something to keep in mind for the future.

@mischah
Copy link
Member

mischah commented Mar 25, 2017

Good idea. When working in a team the following also might be helpful:

  • post-merge: npm install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants