This repository has been archived by the owner on Mar 26, 2018. It is now read-only.
Fix incorrect npmignore sniffing #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #240 Regression introduced in f9e2d0d#diff-2018087f584c4398b5c3a23fc0e5f9dbR60
|
Change looks good to me
|
|
@samccone just catching up on things now that I'm back home. Do you think this is ok to merge? |
|
Yep a merge and new release shoukd be swell |
robdodson
added a commit
that referenced
this pull request
Oct 25, 2015
Fix incorrect npmignore sniffing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #240
Regression introduced in
f9e2d0d#diff-2018087f584c4398b5c3a23fc0e5f9dbR60
cc @addyosmani @robdodson
(tested locally this time, by renaming .gitignore to .npmignore)