Added asset revision. #293
Conversation
* adds two new plugins: rev-all and rev-napkin * Rev-all takes care of adding revisions numbers to assets. * Rev-Napkin removes the (duplicate) un-revved files from the stream * moved HTML minification to the build task, as it interferes with the revision management * added default ignores for revisons: all html files, favicon, touch-icons and robots.txt
|
It seems to work correctly and gives a nice colorful output.
Two questions:
@sindresorhus your thoughts as the author of gulp-rev? 😃 |
|
@silvenon Not sure what more to say. I've already said I don't like this complication and I think it will cause a lot of support requests, but totally up to you. You're also not using |
|
Ok, I take full responsibility if it gets out of hand 😃 I'd like to continue with this then, so @hivre, when you have time, please address my 2 questions. |
| @@ -131,7 +130,12 @@ gulp.task('wiredep', function () { | |||
| }); | |||
|
|
|||
| gulp.task('build', ['jshint', 'html', 'images', 'fonts', 'extras'], function () { | |||
| return gulp.src('dist/**/*').pipe($.size({title: 'build', gzip: true})); | |||
| return gulp.src('dist/**/*', {base: 'dist'}) | |||
| .pipe($.revAll({ignore: ['favicon.ico', 'apple-touch-icon.png', 'robots.txt', '.html']})) | |||
There was a problem hiding this comment.
New Feature: Ignoring files has changed, ignore option has been removed and has been replaced with dontGlobal, dontRenameFile, dontUpdateReference, dontSearchFile which allows for more control and less ambiguity on what is being ignored
|
ping @hivre - also needs a rebase :) |
|
We'll have to continue this in another PR, one of these days 😃 |
|
I'm sorry for the lack of communications. Startup collapsed, new job busy which didn't have any programming. If it is still needed, i'm happy to finish this. I noticed a new version of the revving plugins that solve some issues we had before. |
|
Sure, if you're up for finishing, I'd be happy to merge 😉 |
|
Great. |
|
No pressure. |
|
see #360 for a new attempt. from an earlier comment:
done
done (set debug: true in the options list to get it back) Close this one? |
|
👍 |
See the discussion at #255 this is the napkin-solution.
I have made the least changes to the current setup of the gulp file.