Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gulp-postcss to 5.0 #298

Merged
merged 1 commit into from Apr 6, 2015
Merged

Update gulp-postcss to 5.0 #298

merged 1 commit into from Apr 6, 2015

Conversation

ai
Copy link
Contributor

@ai ai commented Apr 5, 2015

gulp-postcss 4.0 uses very old version of PostCSS and some of users have a problems

/cc @silvenon

@silvenon
Copy link
Member

silvenon commented Apr 5, 2015

I couldn't get gulp-postcss v5.0.0 to work. I'm not sure if I'm doing anything wrong or it's just broken…

stream.js:94
      throw er; // Unhandled stream error in pipe.
            ^
ReferenceError: Promise is not defined
    at LazyResult.async (/Users/matija/Code/test/webapp/node_modules/gulp-postcss/node_modules/postcss/lib/lazy-result.js:93:31)
    at LazyResult.then (/Users/matija/Code/test/webapp/node_modules/gulp-postcss/node_modules/postcss/lib/lazy-result.js:56:21)
    at Transform.stream._transform (/Users/matija/Code/test/webapp/node_modules/gulp-postcss/index.js:44:10)
    at Transform._read (_stream_transform.js:179:10)
    at Transform._write (_stream_transform.js:167:12)
    at doWrite (_stream_writable.js:226:10)
    at writeOrBuffer (_stream_writable.js:216:5)
    at Transform.Writable.write (_stream_writable.js:183:11)
    at Stream.ondata (stream.js:51:26)
    at Stream.emit (events.js:95:17)

@ai
Copy link
Contributor Author

ai commented Apr 5, 2015

Latest PostCSS uses Promises. But I saw that your package.json requires node.js >= 0.12, as I understand.

@ai
Copy link
Contributor Author

ai commented Apr 5, 2015

I asked gulp-postcss author to add polyfill for old node.

@ai
Copy link
Contributor Author

ai commented Apr 5, 2015

We fix gulp-postcss for node.js. PostCSS 4.1.3 now contains polyill.

@silvenon
Copy link
Member

silvenon commented Apr 5, 2015

Thanks. So we need to add es6-promise to package.json as well, right?

@ai
Copy link
Contributor Author

ai commented Apr 5, 2015

@silvenon nope, PostCSS 4.1.3 already has es6-promise in own dependencies.

@silvenon
Copy link
Member

silvenon commented Apr 5, 2015

I think you accidentally added it to devDependencies instead of dependencies 😃

@ai
Copy link
Contributor Author

ai commented Apr 5, 2015

@silvenon yeap :( wait a second

@ai
Copy link
Contributor Author

ai commented Apr 5, 2015

Fix released in PostCSS 4.1.4.

@silvenon
Copy link
Member

silvenon commented Apr 6, 2015

It works, thanks! 👍

silvenon added a commit that referenced this pull request Apr 6, 2015
Update gulp-postcss to 5.0
@silvenon silvenon merged commit 284aa75 into yeoman:master Apr 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants