Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output of remote() has changed a little #414

Closed
jdespatis opened this issue Nov 18, 2013 · 2 comments
Closed

Output of remote() has changed a little #414

jdespatis opened this issue Nov 18, 2013 · 2 comments

Comments

@jdespatis
Copy link
Contributor

Until 0.14, the output of this command has changed,

We have now, when we do a remote():

     info ... Fetching http://github.com/symfony/symfony-standard/archive/v2.3.7.tar.gz ...
     info This might take a few moments
....✔ Done in /home/jerome/.cache/yeoman/symfony/symfony-standard/v2.3.7

Before, there was a linefeed at the end of the ..., the output was then:

     info ... Fetching http://github.com/symfony/symfony-standard/archive/v2.3.7.tar.gz ...
     info This might take a few moments
....
✔ Done in /home/jerome/.cache/yeoman/symfony/symfony-standard/v2.3.7

=> Hence my question, is this change expected, or is it a small cosmetic bug ?

Thanks for your feedback

@jdespatis
Copy link
Contributor Author

Thanks for the PR, however the result is now:

    info ... Fetching http://github.com/symfony/symfony-standard/archive/v2.4.1.tar.gz ...
     info This might take a few moments
....✔ 
Done in /home/jerome/.cache/yeoman/symfony/symfony-standard/v2.4.1

Which is not the previous behavior, which was:

    info ... Fetching http://github.com/symfony/symfony-standard/archive/v2.4.1.tar.gz ...
     info This might take a few moments
....
✔ Done in /home/jerome/.cache/yeoman/symfony/symfony-standard/v2.4.1

Further more, it doesn't align with other messages

I've looked at the history to understand why behavior has changed, it comes from:
a9259ba#diff-a78d7bae20e530a9078d7addb7c4f7d1

The fix is to go back to the code log.write().ok("Done..."), instead of log.ok("\nDone...");

I add a PR for that

@jdespatis
Copy link
Contributor Author

=> PR:
#482

SBoudrias added a commit that referenced this issue Jan 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant