Fix #414 #482
Merged
Fix #414 #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go back to previous behavior, in order to have:
```
info This might take a few moments
....
✔ Done in /home/jerome/.cache/yeoman/symfony/symfony-standard/v2.4.1
```
|
I think this should be solved by adding a newline after |
SBoudrias
added a commit
that referenced
this pull request
Jan 26, 2014
|
As the dots |
|
@SBoudrias i don't like that we have to care about the dots being precedent. Can't you just print and '\n' on the end event after data events have occurred? |
|
@sindresorhus Isn't this what is happening here? |
|
@SBoudrias yes, but we do it explicitly. It should just happen.
We have to add the extra .write() because the dots is precedent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go back to previous behavior, in order to have: