Only build and deploy docs on a specific node version #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischah
commented
Nov 9, 2016
| @@ -16,5 +16,5 @@ env: | |||
| - DOCS_DIR: "../yeoman-generator-doc" | |||
| - GH_OWNER: yeoman | |||
| - GH_PROJECT_NAME: generator | |||
| - PACKAGE_NAME: yeoman-generator | |||
| - DEPLOY_ON_NODE_VERSION: v6 | |||
There was a problem hiding this comment.
You can define the Node version on which the docs should be generated and deployed in the .travis.yml.
|
I think validating if there's changes or not can still be a valid check. |
|
Yeah was unsure about that. Gonna bring it back. |
|
»Change detection« is back. |
SBoudrias
reviewed
Nov 9, 2016
| @@ -40,20 +46,16 @@ echo -e "Generated docs\n" | |||
| # Change directory to $DOCS_DIR | |||
| cd $DOCS_DIR | |||
|
|
|||
| # Flatten content of $DOCS_DIR | |||
| mv $PACKAGE_NAME/**/** ./ | |||
There was a problem hiding this comment.
Is this not necessary anymore?
There was a problem hiding this comment.
Nope. It was needed to cleanup the directory mess caused by JSDoc when passing a package.json.
There was a problem hiding this comment.
That was how it looked.
Ist now flat again by default.
|
Cool! Let's merge this 😄 |
|
🙆♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified the prevention of multiple commits of docs in
gh-pagesbranch as discussed in #975