Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

uglifyjs post-processor - incorrect example #409

Closed
zuzana opened this issue Jul 23, 2014 · 2 comments · Fixed by #520
Closed

uglifyjs post-processor - incorrect example #409

zuzana opened this issue Jul 23, 2014 · 2 comments · Fixed by #520

Comments

@zuzana
Copy link

zuzana commented Jul 23, 2014

Example about how to customize the generated configuration via post-processors in flow option should have:

name: 'uglify'

instead of

name: 'uglifyjs'

because it causes following error:

Fatal error: Cannot set property 'options' of undefined

It might be useful to have module uglifyjs.js export name 'uglifyjs' so it is consistent with step name and module name and prevents unnecessary errors :)

@donaldpipowitch
Copy link
Contributor

You're right this is quite inconsistent. But I would deprecate 'uglifyjs' inside steps and use 'uglify' instead. I would do it this way around, because 'uglify' is the real task name of grunt-contrib-uglify.

@eddywashere
Copy link

Nice catch! I actually gave up on a similar error I came across months ago and was hoping it was fixed by now. Thanks for this post!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants