-
Notifications
You must be signed in to change notification settings - Fork 338
Usemin 2.0 #85
Comments
👍 |
👍 I would also like to see anything that could be generic made into a separate node module. |
@sindresorhus Any precise idea ? |
The cssprocessor, htmlprocessor and revfinder might be useful outside of usemin if refactored, though haven't looked at them in-depth. |
Work in progress in branch v2.0 of sleeper/grunt-usemin |
The new flow system looks really awesome. This will make usemin a lot easier and more transparent to use. |
Yes, I hope so. |
I also think a goal of 2.0 should be to make it faster. Currently it takes some time to run. Some ideas:
|
Ok for the perfs. |
@sleeper good point, that would be difficult. maybe run multiple files in parallell then. |
Yes, I was more on this side ;) Frederick Ros Le jeudi 4 avril 2013 à 13:56, Sindre Sorhus a écrit :
|
What's the status on 2.0? Being able to configure the pipeline for individual blocks would be a feature very much appreciated. In my case I would like to disable uglifyjs when concatenating third party code. On top of that, if it were possible to switch out those referenced JS files with their preminified equivalents (provided that they exist, which they often do in case of Bower components) before the concatenation step, that would be even better. I am aware of many different grunt tasks for combining Bower components, but in the end they often fail due to the fact that hardly any Bower components are correctly configured (main file definition(s), dependencies). |
Please can we get this in a branch on this repo. Doesn't need to be in a state that's suitable for merging into master any time soon. |
Will do tonight. |
Oki doki. Branch v2.0 created and populated. Note that a lot needs to be done yet:
Additionally, in order to be more efficient I submitted a PR to Test are passing, but I still need to test it on real stuff ;) |
|
Agreed. Also:
|
Added option to look for file in a map object instead of on file |
@sleeper what's the status of the rewrite? :) |
What is missing so far:
We also need to push to have the PR for |
Would it be worth breaking any of the more generic tasks into separate packages, like grunt-rev was. |
Yes, I was thinking about this as well... Let's say that in a first phase, I would like to be sure it really works, and then split what can be split ... Not sure I have a lot of generic stuff there though ;) |
OK, so last changes:
|
@sleeper: Will usemin blocks in 2.0 have the ability to set alternate search paths like the ones described in yeoman/yeoman#959? |
Humm .. this is not exactly what I have ... the alternate path are used as alternate search path, not alternate output path ... |
I think those describe alternate search paths. So <!-- build:js(app,.tmp) scripts/tmp.js -->
...
<!-- endbuild --> would look in .tmp then app for a script or stylesheet to add to the concatenation array. It addresses a couple of existing issues and would allow the build process and the server process to follow the same pattern in generators with preprocessors. |
Oh, my fault I didn't read properly the issue you were mentioning. |
From what I see it doesn't cascade (app then .tmp), which is useful if you need to concatenate preprocessed css/js with vanilla css/js that lives in app. Would it be better for me to open a separate issue with use case, references, etc? |
yep, it would be simple ;) |
Thanks! New issue posted. |
@sleeper hey man. How far along is the rewrite at this point? |
I would say a couple of things to review/fix, plus rebasing on master to get the patch that have been incorporated on master since the initial branching ... which is not really cool, considering some people have probably checked out this branch .. but considering the huge amount of changes this is the only suitable way to do it ... |
That's great to hear. Would be nice to get it into generator-webapp soon to test it out ;) |
Many anxious users ready to rock and roll version 2! On Fri, Jul 19, 2013 at 8:42 PM, Frederick Ros notifications@github.comwrote:
|
@sleeper how do you feel about doing the 2.0 release this/next week? Usemin 1.0 has a lot of problems and would be a great help to people if they got 2.0 ;) |
There's sure lots of folk dying in anticipation. I'm one of them! |
Sorry for the delay in answering, I have/had lot of work plus additional things that kept me far from my duties ;) From my point of view In my view, we should ask for a wider test by integrating it with |
Thanks for the update @sleeper and no worries :) Anyone up for doing a PR on generator-webapp? |
What's to be updated? Seems like it should work out of the box. Maybe we need to change |
@kevva i haven't looked at it closely, but you're probably right. Most important thing is testing all edge cases and reporting back if something isn't working. |
Implemented in yeoman/generator-webapp@40a2595. Could we release this soon @sleeper? |
Christmas morning feelings. |
Dudes, sorry for being so absent these days. |
Version 0.1.13 published: last head version before merge ;) |
Holly crap dudes: Enjoy !! |
👏 |
Awesome! Thanks for doing that @sleeper :D We should get out a new release of generator-webapp |
Usemin needs a big overhaul to be simpler to understand and use, and be more configurable.
Namely we need:
useminPrepare
(e.g. users may want to disable uglifyjs, concat, ..)usemin
(e.g. add for example create a new parser for AngularJS)The text was updated successfully, but these errors were encountered: