-
Notifications
You must be signed in to change notification settings - Fork 338
fix #307 - grunt-watch spawn:false compatibility fix #323
fix #307 - grunt-watch spawn:false compatibility fix #323
Conversation
Can you explain the fix and add a test? |
Sorry for the late response. I hope this description helped, but let me know If there is any more questions. I added a test. Probably it is possible to create a shorter but I hope this is more meaningful. If you run the test for the non-patched version and you add this line before the deepEquals assertion in the new test, you will see what was the original problem: console.log(config.concat.generated.files); |
I cleaned a bit this pull request. (rebased a few times, and fixed the js linting errors.) I hope the rebases don't cause any trouble. |
ping. |
@vlajos can you add a comment in the source file explaining the reason of the You need to update your code as it violate the jscs rule "one space before opening curly brace". See build output |
… file with the same destination update only the source part, instead of add the whole block again. This way the same targets wont be regenerated multiple times if usemin is called multiple times which can happen with grunt-watcher spawn:false mode
40ba284
to
ab78ca9
Compare
ab78ca9
to
5ef5c0d
Compare
5ef5c0d
to
a84df9d
Compare
a84df9d
to
f9b193c
Compare
Done. |
LGTM |
…bility fix.
if the newly generated part is already in the config file with the same destination update only the source part, instead of add the whole block again. This way the same targets won't be regenerated multiple times if usemin is called multiple times which can happen with grunt-watcher spawn:false mode.