This repository has been archived by the owner on Apr 20, 2018. It is now read-only.
Duplicate blocks should raise a warn instead of a fatal error #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
added a commit
that referenced
this pull request
Dec 11, 2014
Duplicate blocks should raise a warn instead of a fatal error
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not long ago we got a merged PR that avoid duplicated config blocks. That piece is working really well, the problem is just that inside the useminPrepare task we are invoking a
grunt.fail.fatalerror that just kills the plugin for everyone that happens to have a duplicated block somewhere. 馃槥As you can see in the discussion that follows on that same PR we have an increased number of feedback from people that have duplicated blocks around their apps and can't use the plugin anymore or are just hacking around the functionality.
My humble suggestion is to change grunt.fail.fatal error into a grunt.fail.warn so that people wanting to
--forcethat kind of behaviour will be allowed to do so.Thanks!