Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to AVA for testing #121

Merged
merged 2 commits into from
Sep 29, 2017
Merged

Move to AVA for testing #121

merged 2 commits into from
Sep 29, 2017

Conversation

timdeschryver
Copy link
Contributor

With this change all tests are being run with AVA instead of mocha.

Copy link
Contributor Author

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uncertainties

});
let updateNotifier = require('../');

test.before(() => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, I removed the test.after.
Is this OK?


let errorLogs = '';

test.beforeEach(() => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, I removed the test.after.
Is this OK?

@sindresorhus sindresorhus merged commit 6f2b074 into yeoman:master Sep 29, 2017
@sindresorhus
Copy link
Member

Thanks :)

@timdeschryver timdeschryver deleted the pr/ava branch September 29, 2017 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants