New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce dependency tree #165
Comments
I agree, it couldn't hurt trimming it down a bit. Though the install will take some time anyway, because of everything install.sh has to fetch and install. There has been some relevant discussion on the grunt repo about if it's necessary for grunt plugins to have grunt as a dependency - no conclusion. cowboy/grunt#263 The additional grunt dependencies with subs is like half of the dependency-tree. |
Very true. @sindresorhus whoa, I completely missed that issue on grunt repo. Will add a few words there too.. IMHO, this is an unnecessary (and quite annoying actually) thing to have grunt plugins rely on grunt, when they really shouldn't. If a plugin is not exposing a cli API, is just exposing a task/ directory and is not directly using (eg. I feel that putting grunt dep in those plugin as a As you said, half of our dep tree is related to that, and the fact that the grunt plugins we rely on define grunt as a project dependency. To help with this, we might:
It would help us a lot, then we might improve this dep tree a bit more by removing some unnecessary dep or stuff we can pull in from grunt.utils (like async and underscore). In a next step, inclusion of grunt-contrib might help us remove most of the remaining deps we might have (like tar, mkdirp, rimraf and so on). |
Couldn't agree more :) |
commented on cowboy/grunt#263. filed these PRs: kmiyashiro/grunt-mocha#6 |
Awesome, thanks a lot Paul. Until these PRs are accepted in their respective repo and published to npm, we might want to point each deps in our package.json to your forks (I'm sure it won't be necessary). |
successfully got both deps to clear out grunt and bump. hooray!
probably helps remove some, but certainly doesn't help with dep tree size or install time. :/ |
closing this for now. i think we had MUCH SUCCESS! |
Awesome Paul :) Current dependency tree: (takes about 16sec on my Mac)
|
It's pretty big these days.. could use some pruning
We rely on a specific SHA of grunt inside 0.4.0a and hopefully we'll have 0.4 final to use soon. In the meantime our grunt tasks we pull in rely on
0.3.10
and0.3.11
of grunt, which ends up pulling in quite a few things.My primary aim is reducing install time here.. can someone do a pass on cleaning up any superfluous deps?
The full dep tree:
The text was updated successfully, but these errors were encountered: