Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce dependency tree #170

Merged
merged 6 commits into from Jul 31, 2012
Merged

reduce dependency tree #170

merged 6 commits into from Jul 31, 2012

Conversation

mklabs
Copy link
Contributor

@mklabs mklabs commented Jul 30, 2012

It's not much, but should help a bit on this dependency tree issue #165

  • remove direct references to async / underscore, pull them from grunt.util
  • remove references ot ncp, no longer used in favor of fstream
  • match connect / prompt deps to the exact same version than grunt's deps

on the commit we rely on currently:

should be kept up to date whenever we change the grunt version we rely on. The idea is to match the version of the dependencies we have with the ones that are also defined as grunt's dependency.


Next step would be to do a pull request on both grunt plugins currently we rely on: grunt-mocha and grunt-jasmine-task. We rely on grunt 0.4.x, they rely on grunt 0.3.x. Version mismatch, npm resolves them separately. We can fix it by:

  • switching back to grunt 0.3.x
  • wait for grunt 0.4.x to comes out and wait for each plugin to update their grunt version.
  • Do a PR to move their grunt dependency as a devDependency, if accepted by the author.

Best is probably the latter option. I can initiate the respective PRs if you wish me to do so. In the meantime, until it's hopefully accepted and published to npm, we can point our deps to one of our forks.

@mklabs
Copy link
Contributor Author

mklabs commented Jul 30, 2012

  • Getting an error at this line in the server task with the updated connect version, should change the instanceof check to be against require('http').Server.

  • downgraded prompt version to match grunt one: slight change required in insight prompt, currently output:

    ==============================
    We're constantly looking for ways ... 
    ==============================
    [?] undefined
    

Otherwise, tests pass.

@sindresorhus
Copy link
Member

Do a PR to move their grunt dependency as a devDependency, if accepted by the author.

This one ;)

@addyosmani
Copy link
Member

Great work on getting this started, @mklabs. I agree with the direction you've taken.

I can initiate the respective PRs if you wish me to do so. In the meantime, until it's hopefully accepted and published to npm, we can point our deps to one of our forks.

Absolutely. If you have time it would be brilliant to get the rest tackled too!

addyosmani added a commit that referenced this pull request Jul 31, 2012
@addyosmani addyosmani merged commit 2c21d57 into yeoman:master Jul 31, 2012
@addyosmani
Copy link
Member

Thanks @mklabs!

szinya pushed a commit to menthainternet/yeoman that referenced this pull request Sep 17, 2014
addyosmani added a commit that referenced this pull request Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants